refactor: hide internal event._res and event.res._headers#1185
Merged
refactor: hide internal event._res and event.res._headers#1185
event._res and event.res._headers#1185Conversation
Member
|
Thanks for PR. It breaks tests since in response handler we need to access intermediate headers and avoid triggering slow path: Line 72 in 8972b0f We could use ~ instead. |
Contributor
Author
oh this line will error? |
_res and res._headers
_res and res._headersevent._res and event.res._headers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this hides props from the user that they should not use