Skip to content

perf(getRequestIP): improve performances #1197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pi0 merged 2 commits into from
Sep 29, 2025
+5 −3
Merged

perf(getRequestIP): improve performances #1197

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
81bc7b3
:zap: Slightly improve `getRequestIP` performances
homersimpsons Aug 29, 2025
61f49a4
Merge branch 'main' into perf/getRequestIP
pi0 Sep 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/utils/request.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,9 +374,11 @@ export function getRequestIP(
if (opts.xForwardedFor) {
// https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/X-Forwarded-For#syntax
const _header = event.req.headers.get("x-forwarded-for");
const xForwardedFor = (_header || "")?.split(",").shift()?.trim();
if (xForwardedFor) {
return xForwardedFor;
if (_header) {
const xForwardedFor = _header.split(",")[0].trim();
if (xForwardedFor) {
return xForwardedFor;
}
}
Comment thread
pi0 marked this conversation as resolved.
}

Expand Down