Skip to content

refactor(createRouter): deprecate misspelled preemptive option#256

Merged
pi0 merged 1 commit intoh3js:mainfrom
nozomuikuta:fix/deprecate-misspelled-option
Nov 30, 2022
Merged

refactor(createRouter): deprecate misspelled preemptive option#256
pi0 merged 1 commit intoh3js:mainfrom
nozomuikuta:fix/deprecate-misspelled-option

Conversation

@nozomuikuta
Copy link
Copy Markdown
Contributor

Resolves #255.

cc: @AaronSmithX

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 29, 2022

Codecov Report

Merging #256 (8e1785b) into main (9ea0da6) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #256      +/-   ##
==========================================
+ Coverage   75.90%   75.94%   +0.03%     
==========================================
  Files          20       20              
  Lines        1216     1218       +2     
  Branches      224      224              
==========================================
+ Hits          923      925       +2     
  Misses        293      293              
Impacted Files Coverage Δ
src/router.ts 94.84% <100.00%> (+0.10%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Comment thread src/router.ts
Copy link
Copy Markdown
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pi0 pi0 changed the title fix: deprecate misspelled preemptive option refactor(createRouter): deprecate misspelled preemptive option Nov 30, 2022
@pi0 pi0 merged commit c0aa9c6 into h3js:main Nov 30, 2022
@nozomuikuta nozomuikuta deleted the fix/deprecate-misspelled-option branch November 30, 2022 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CreateRouterOptions misspelling of "preemptive"

3 participants