Skip to content

fix(clearSession): accept partial session config#328

Merged
pi0 merged 2 commits intoh3js:mainfrom
zhiyuanzmj:refactor/clearSession-type
Feb 20, 2023
Merged

fix(clearSession): accept partial session config#328
pi0 merged 2 commits intoh3js:mainfrom
zhiyuanzmj:refactor/clearSession-type

Conversation

@zhiyuanzmj
Copy link
Copy Markdown
Contributor

@zhiyuanzmj zhiyuanzmj commented Feb 14, 2023

// before need `password`
await clearSession(event, {password: '...'})

//  after
await clearSession(event)

Comment thread src/utils/session.ts Outdated
Copy link
Copy Markdown
Contributor Author

@zhiyuanzmj zhiyuanzmj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feat(clearSession): password optional

Comment thread src/utils/session.ts Outdated
@pi0 pi0 changed the title refactor(clearSession): set the config parameter optional fix(clearSession): accept partial session config Feb 20, 2023
Copy link
Copy Markdown
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pi0 pi0 merged commit 80f2c61 into h3js:main Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants