Skip to content

fix(setResponseStatus): mark code type as optional#359

Merged
pi0 merged 1 commit intomainfrom
fix/response-type
Mar 15, 2023
Merged

fix(setResponseStatus): mark code type as optional#359
pi0 merged 1 commit intomainfrom
fix/response-type

Conversation

@danielroe
Copy link
Copy Markdown
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

We now check if code exists, which is important if this util is being used just to set the statusMessage.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug Something isn't working label Mar 15, 2023
@danielroe danielroe requested a review from pi0 March 15, 2023 21:59
@pi0 pi0 changed the title fix: mark code as optional fix(setResponseStatus): mark code type as optional Mar 15, 2023
@pi0 pi0 merged commit 77e66df into main Mar 15, 2023
@pi0 pi0 deleted the fix/response-type branch March 15, 2023 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants