fix(readBody, readRawBody): handle raw body as buffer#366
Conversation
Buffer in readBody
Member
|
Thanks for the PR. I have pushed couple of changes to handle it also for readRawBody consistently + tests |
Codecov Report
@@ Coverage Diff @@
## main #366 +/- ##
==========================================
+ Coverage 74.57% 74.77% +0.19%
==========================================
Files 26 26
Lines 2407 2406 -1
Branches 380 381 +1
==========================================
+ Hits 1795 1799 +4
+ Misses 612 607 -5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Member
|
Related fix 19d133d |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
readBodyneeds to handleBuffer#363I'm not sure if this implementation is enough. For my use-case in nuxt-api-party:
… this change fixed handling
Bufferrequests, e.g. when sending POST requests in a Cloudflare Nitro worker.