feat(proxy): support onResponse callback#368
Merged
Conversation
Contributor
Author
|
@pi0 Can we merge this one? It doesn't make any breaking change. |
pi0
reviewed
Apr 28, 2023
| } | ||
|
|
||
| if (opts.onResponse) { | ||
| await opts.onResponse(event); |
Member
There was a problem hiding this comment.
It would be also nice to pass over the actual response as second argument
Codecov Report
@@ Coverage Diff @@
## main #368 +/- ##
==========================================
+ Coverage 74.80% 74.85% +0.05%
==========================================
Files 26 26
Lines 2409 2414 +5
Branches 383 385 +2
==========================================
+ Hits 1802 1807 +5
Misses 607 607
|
Contributor
Author
|
Hi @pi0, |
|
Waiting for merge! This feature could potentially help to fix nitrojs/nitro#1237 and #376 |
pi0
approved these changes
Jun 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #354
This PR adds
onResponsecallback tosendProxyandproxyRequestutilities.It accepts proxy
eventas argument which can be used to modify the response headers, cookies etc.:It can also be async: