refactor: use event.path instead of event.node.req.url #438
Merged
Conversation
Member
Author
|
Need to triple check this is important to avoid perf penalties and regression 😅 |
Codecov Report
@@ Coverage Diff @@
## main #438 +/- ##
==========================================
+ Coverage 77.76% 77.89% +0.13%
==========================================
Files 26 26
Lines 2698 2705 +7
Branches 399 393 -6
==========================================
+ Hits 2098 2107 +9
+ Misses 600 598 -2
|
Member
Author
|
Have made some additional tests seems all is fine also with compatibility. Heads up @danielroe @antfu @atinux if you discovered any issues with next release please ping me to quickly check. |
This was referenced Jul 24, 2023
Closed
8 tasks
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…al utils
🔗 Linked issue
#73
❓ Type of change
📚 Description
This PR:
event._originalPathinternal (resolves useevent._originalPathinternal helper #435)event._pathinternal and uses it to cache+overrideevent.pathgetter valuegetRequestPath(event)to preferevent.pathevent.pathinstead ofevent.node.req.urlWith this, we reduce dependency in
event.node📝 Checklist