fix(proxy): respect fetchOptions.method over incoming request method#441
Conversation
If fetchOptions.method passed use it. Prevents "body" assign
Contributor
|
Would you add unit test? |
Codecov Report
@@ Coverage Diff @@
## main #441 +/- ##
=======================================
Coverage 77.74% 77.74%
=======================================
Files 26 26
Lines 2692 2692
Branches 393 394 +1
=======================================
Hits 2093 2093
Misses 599 599
|
fetchOptions.method over incoming request method
pi0
reviewed
Jul 17, 2023
Member
|
Adding an additional test would be nice btw (however is not necessary) |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
❓ Type of change
📚 Description
When
proxyRequestis used with differentmethod(e.g. GET) defined infetchOptions, thebodyis still filled and returnsRequest with GET/HEAD method cannot have body.📝 Checklist