refactor: use native Headers and Response for legacy polyfills#523
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #523 +/- ##
==========================================
+ Coverage 82.15% 83.73% +1.58%
==========================================
Files 32 31 -1
Lines 3665 3542 -123
Branches 540 540
==========================================
- Hits 3011 2966 -45
+ Misses 654 576 -78
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
❓ Type of change
📚 Description
In h3 1.8, we have changed to rely on native global
HeadersandResponseobjects.To avoid breaking changes, we have kept the (unused)
H3HeadersandH3Responsepolyfills in case users by any chance were using them and introduce a breaking change to the exports.Since objects like
Headersare under development and h3 polyfills lacked many methods includingtoClone()i think it is just safer to redirect those to native globals as H3 (and Nuxt/Nitro) expect (and polyfill) them anyway and are available in recent versions of Node.js.📝 Checklist