Skip to content

fix(getRequestProtocol): conditionaly check connection?.encrypted#532

Merged
pi0 merged 1 commit intoh3js:mainfrom
michealroberts:fix/utility/getRequestProtocol
Sep 26, 2023
Merged

fix(getRequestProtocol): conditionaly check connection?.encrypted#532
pi0 merged 1 commit intoh3js:mainfrom
michealroberts:fix/utility/getRequestProtocol

Conversation

@michealroberts
Copy link
Copy Markdown
Contributor

fix: add optional chain (.?) to event connection check in getRequestProtocol

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

A minor change, but essentially if event.node.req.connection is undefined ... we can't check for the encrypted boolean value, therefore an optional chain has been added.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

…getRequestProtocol

fix: Added optional chain (.?) to event.node.req.connection check in getRequestProtocol
@pi0 pi0 changed the title fix: add optional chain (.?) to event connection check in getRequestProtocol fix(getRequestProtocol): conditionaly check connection?.encrypted Sep 26, 2023
@pi0 pi0 merged commit 9427e18 into h3js:main Sep 26, 2023
@pi0
Copy link
Copy Markdown
Member

pi0 commented Sep 26, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants