fix(proxy): better error when upstream proxy fails#746
Merged
Conversation
Deploying unjs-h3 with
|
| Latest commit: |
dc9f019
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://cfe56f7c.unjs-h3.pages.dev |
| Branch Preview URL: | https://fix-proxy-500.unjs-h3.pages.dev |
7efd102 to
22faf28
Compare
pi0
reviewed
May 7, 2024
Contributor
Author
|
Updated to
You mean an existing one in |
c5922e7 to
2fdd48f
Compare
pi0
approved these changes
Jun 19, 2024
Member
pi0
left a comment
There was a problem hiding this comment.
Thanks ❤️ (updated impl to still throw error to allow hooking into it but with createError)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
#722
❓ Type of change
📚 Description
This PR should ensure that
proxyRequests fail gracefully instead of leading to an unhandled node error crashing the server.📝 Checklist