Conversation
Member
Author
|
now I feel there must have been more to your thinking - so happy to close this if you had something more elaborate in mind... |
pi0
approved these changes
Nov 22, 2020
Member
pi0
left a comment
pi0
left a comment
There was a problem hiding this comment.
Actually it is perfect (if you mind directly updating docs in main would be awesome)
I created issue as a task also reminder to support it for sort method if added
danielroe
added a commit
that referenced
this pull request
Nov 22, 2020
* add corresponding test * update types follow-up to #9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #5