Create core/hab-bintray-publish for Bintray publishing, right?
#709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fletcher Nichol <[email protected]>
Signed-off-by: Fletcher Nichol <[email protected]>
Signed-off-by: Fletcher Nichol <[email protected]>
This change adds an additional piece of support software, under
`support/bintray-publish`, which automates the delivery of `hab` CLI
artifacts and Studio Docker images to Bintray for initial consumption.
As all plans, this can be build with:
hab pkg build ./support/bintray-publish
Which produces a `core/hab-bintray-publish` package. There are 2
programs provided:
* `publish-hab` - used to take a Habitat package of `hab` and publish it
to Bintray
* `publish-studio` - used to create and push a Docker image of a
pre-created Studio instance
Both of these programs require login credentials to do their work and
these are consumed via environment variables. They will both fail if any
of the required environment variables are not set, but for clarity, the
following are used:
* `BINTRAY_USER` - username
* `BINTRAY_KEY` - an API key for the username
* `BINTRAY_PASSPHRASE` - the passphrase for the GPG-signing key on
the Bintray platform
Signed-off-by: Fletcher Nichol <[email protected]>
|
By analyzing the blame information on this pull request, we identified @adamhjk to be a potential reviewer |
|
A rough simulation of the deployment process:
|
| ln -snf $certs /etc/ssl/certs/ca-certificates.crt | ||
| fi | ||
| export LD_LIBRARY_PATH="$LD_RUN_PATH" | ||
| exec $(pkg_path_for glibc)/lib/ld-linux-x86-64.so.2 ${bin}.real \$@ |
There was a problem hiding this comment.
man, really? we can't just patch the binary like normal humans?
There was a problem hiding this comment.
Isn't that the best? Turns out Go binaries are their own breed and patchelf has issues coping.
That function started off so wicked, until I needed SSL certs. From what I could tell Go doesn't honor any environment variables for these, but does absolute hard coded path lookups. The line 33-37 is evil, but the rest was almost a universal solution for cgo-compiled binary that we didn't build.
Also, I really wanted to see this frog fly, as is were. Whee!
|
This looks legit. Lets do it.
|
|
📌 Commit 6f5d701 has been approved by |
thesentinels
pushed a commit
that referenced
this pull request
Jun 10, 2016
Signed-off-by: Fletcher Nichol <[email protected]> Pull request: #709 Approved by: adamhjk
thesentinels
pushed a commit
that referenced
this pull request
Jun 10, 2016
Signed-off-by: Fletcher Nichol <[email protected]> Pull request: #709 Approved by: adamhjk
thesentinels
pushed a commit
that referenced
this pull request
Jun 10, 2016
Signed-off-by: Fletcher Nichol <[email protected]> Pull request: #709 Approved by: adamhjk
thesentinels
pushed a commit
that referenced
this pull request
Jun 10, 2016
This change adds an additional piece of support software, under
`support/bintray-publish`, which automates the delivery of `hab` CLI
artifacts and Studio Docker images to Bintray for initial consumption.
As all plans, this can be build with:
hab pkg build ./support/bintray-publish
Which produces a `core/hab-bintray-publish` package. There are 2
programs provided:
* `publish-hab` - used to take a Habitat package of `hab` and publish it
to Bintray
* `publish-studio` - used to create and push a Docker image of a
pre-created Studio instance
Both of these programs require login credentials to do their work and
these are consumed via environment variables. They will both fail if any
of the required environment variables are not set, but for clarity, the
following are used:
* `BINTRAY_USER` - username
* `BINTRAY_KEY` - an API key for the username
* `BINTRAY_PASSPHRASE` - the passphrase for the GPG-signing key on
the Bintray platform
Signed-off-by: Fletcher Nichol <[email protected]>
Pull request: #709
Approved by: adamhjk
|
☀️ Test successful - travis |
jtimberman
pushed a commit
that referenced
this pull request
Jun 12, 2016
Signed-off-by: Fletcher Nichol <[email protected]> Pull request: #709 Approved by: adamhjk
jtimberman
pushed a commit
that referenced
this pull request
Jun 12, 2016
Signed-off-by: Fletcher Nichol <[email protected]> Pull request: #709 Approved by: adamhjk
jtimberman
pushed a commit
that referenced
this pull request
Jun 12, 2016
Signed-off-by: Fletcher Nichol <[email protected]> Pull request: #709 Approved by: adamhjk
jtimberman
pushed a commit
that referenced
this pull request
Jun 12, 2016
This change adds an additional piece of support software, under
`support/bintray-publish`, which automates the delivery of `hab` CLI
artifacts and Studio Docker images to Bintray for initial consumption.
As all plans, this can be build with:
hab pkg build ./support/bintray-publish
Which produces a `core/hab-bintray-publish` package. There are 2
programs provided:
* `publish-hab` - used to take a Habitat package of `hab` and publish it
to Bintray
* `publish-studio` - used to create and push a Docker image of a
pre-created Studio instance
Both of these programs require login credentials to do their work and
these are consumed via environment variables. They will both fail if any
of the required environment variables are not set, but for clarity, the
following are used:
* `BINTRAY_USER` - username
* `BINTRAY_KEY` - an API key for the username
* `BINTRAY_PASSPHRASE` - the passphrase for the GPG-signing key on
the Bintray platform
Signed-off-by: Fletcher Nichol <[email protected]>
Pull request: #709
Approved by: adamhjk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds an additional piece of support software, under
support/bintray-publish, which automates the delivery ofhabCLI artifacts and Studio Docker images to Bintray for initial consumption.As all plans, this can be build with:
Which produces a
core/hab-bintray-publishpackage. There are 2 programs provided:publish-hab- used to take a Habitat package ofhaband publish it to Bintraypublish-studio- used to create and push a Docker image of a pre-created Studio instanceBoth of these programs require login credentials to do their work and these are consumed via environment variables. They will both fail if any of the required environment variables are not set, but for clarity, the following are used:
BINTRAY_USER- usernameBINTRAY_KEY- an API key for the usernameBINTRAY_PASSPHRASE- the passphrase for the GPG-signing key on the Bintray platform