Skip to content

Upgrade to Rails 7 #3261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 0 commits into from
Closed

Upgrade to Rails 7 #3261

wants to merge 0 commits into from

Conversation

albertchae
Copy link
Contributor

@albertchae albertchae commented Nov 27, 2022

Fixes #3111

Best reviewed by commits. This PR starts by updating the Rails gem and then fixing a few warnings/errors that were happening on boot. Then we go through a few of the recommended rails 7 migration steps (removing spring, running app:update, updating active storage).

  • Update rails gem from 6.1.7 to 7.0.4
  • Silence net-http warnings by adding to Gemfile
  • Force uri version to 0.10.0 (default version in Ruby 2.7)
  • Update maildown gem
  • Remove spring dependency
  • Ran bin/rails app:update
  • Run ActiveStorage migration added by bin/rails app:update

@albertchae albertchae changed the title rails 7 Upgrade to Rails 7 Nov 27, 2022
@garyhtou garyhtou temporarily deployed to bank-hackclu-rails-7-4yopbd0v5 November 27, 2022 10:12 Inactive
Comment on lines 6 to 8
# Uncomment each configuration one by one to switch to the new default.
# Once your application is ready to run with all new defaults, you can remove
# this file and set the `config.load_defaults` to `7.0`.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the next set of PRs should work through this framework config file

@maxwofford maxwofford temporarily deployed to bank-hackclu-rails-7-oaflu8xnz December 9, 2022 19:31 Inactive
@albertchae albertchae temporarily deployed to bank-hackclu-rails-7-oaflu8xnz December 12, 2022 02:52 Inactive
@albertchae albertchae temporarily deployed to bank-hackclu-rails-7-oaflu8xnz December 12, 2022 09:33 Inactive
@albertchae albertchae temporarily deployed to bank-hackclu-rails-7-oaflu8xnz December 15, 2022 08:13 Inactive
@albertchae
Copy link
Contributor Author

I need to rebuild the review app but don't have permissions, so I will close this PR and open a new one.

@albertchae albertchae closed this Dec 15, 2022
@albertchae albertchae deleted the rails-7 branch December 15, 2022 08:30
@garyhtou garyhtou temporarily deployed to bank-hackclu-rails-7-ne-uapxrm December 15, 2022 08:36 Inactive
@albertchae albertchae mentioned this pull request Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to Rails 7
5 participants