Skip to content

fixtures as class attributes #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 26, 2017
Merged

Conversation

skraynev
Copy link
Contributor

@nicoddemus @hackebrot Hi all, sorry for the delay. Could you please review the article, mentioned in:
pytest-dev/pytest#2618

@skraynev
Copy link
Contributor Author

Looks like someone have to merge it :)

Also changed the last example to show the technique being applied
to standard unittest subclasses, as this is probably the main audience
for this article
@nicoddemus
Copy link
Collaborator

@skraynev thanks for the ping, appreciate it!

Hope you don't mind but I made some small changes to grammar and wording in a few places, also changed the second example to show the technique being applied to standard unittest subclasses because I believe this will be the main audience of the article.

Again, thanks for your work on this contribution. @hackebrot would you like to take another look before we merge it?

@skraynev
Copy link
Contributor Author

I have reviewed it rapidly, so I don't mind to merge it with your improvements 👍

@nicoddemus nicoddemus merged commit a4f599f into hackebrot:master Sep 26, 2017
@nicoddemus
Copy link
Collaborator

Thanks again @skraynev!

@little-dude
Copy link

This is a really useful trick. Would you consider making such auto_inject_fixtures decorator part of pytest itself @nicoddemus ?

@nicoddemus
Copy link
Collaborator

Hi @little-dude,

Probably not in my opinion, but I would really love for it to get more prominence somehow...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants