Skip to content

Conversation

@siyunfeng
Copy link
Member

@siyunfeng siyunfeng commented Mar 7, 2025

This PR is to test how to create a new issue to solve 6129

What changes did you make?

  • Created HTML file join-slack-channel.html to navigate how to join Slack channel
  • Changed the URL of Join Slack Channel from the corresponding slack channel to the join-slack-channel.html
  • Added an onclick() in the <a> element of Join Slack Channel to store the Slack channel URL in localStorage

Why did you make the changes (we will use this info to test)?

  • Testing the potential solution to navigate non-members to join HfLA before joining the team Slack channel before writing instructions of creating the issue based on the ER 6129

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied

No related image

Visuals after changes are applied

join-slack-channel-page
hing_Files)

@github-actions
Copy link

github-actions bot commented Mar 7, 2025

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b siyunfeng-add-slack-channel-links-for-non-members gh-pages
git pull https://github.com/siyunfeng/hackforla-website.git add-slack-channel-links-for-non-members

@siyunfeng siyunfeng added the Draft Issue is still in the process of being created label Mar 7, 2025
@github-actions github-actions bot added Status: Help Wanted Internal assistance is required to make progress role: front end Tasks for front end developers Complexity: Large P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) P-Feature: Getting Started https://www.hackforla.org/getting-started P-Feature: Projects page https://www.hackforla.org/projects/ size: 0.25pt Can be done in 0.5 to 1.5 hours ready for product Issue Making: Level 2 Make issue(s) from an ER or Epic Complexity: See issue making label See the Issue Making label to understand the issue writing difficulty level ER Emergent Request and removed Draft Issue is still in the process of being created labels Mar 7, 2025
@siyunfeng siyunfeng removed ready for product ER Emergent Request labels Mar 7, 2025
@daras-cu

This comment was marked as resolved.

@siyunfeng siyunfeng removed the Status: Help Wanted Internal assistance is required to make progress label Mar 11, 2025
@siyunfeng

This comment was marked as resolved.

@siyunfeng siyunfeng closed this Mar 13, 2025
@siyunfeng siyunfeng deleted the add-slack-channel-links-for-non-members branch March 18, 2025 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complexity: Large Complexity: See issue making label See the Issue Making label to understand the issue writing difficulty level Issue Making: Level 2 Make issue(s) from an ER or Epic P-Feature: Getting Started https://www.hackforla.org/getting-started P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) P-Feature: Projects page https://www.hackforla.org/projects/ role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Projects

Development

Successfully merging this pull request may close these issues.

2 participants