Skip to content

Conversation

@jsnhn
Copy link
Member

@jsnhn jsnhn commented Mar 14, 2025

Fixes #7475

What changes did you make?

  • Removed Raji Pradheap information from _projects/home-unite-us.md

Why did you make the changes (we will use this info to test)?

  • To keep list of active members on the Home Unite Us page up-to-date.

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied Screenshot 2025-03-13 at 6 08 35 PM
Visuals after changes are applied Screenshot 2025-03-13 at 6 09 18 PM

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b jsnhn-remove-profile-info-7475 gh-pages
git pull https://github.com/jsnhn/website.git remove-profile-info-7475

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe size: 0.25pt Can be done in 0.5 to 1.5 hours labels Mar 14, 2025
@rogerioduenas
Copy link
Member

Availability: Monday - Friday, 10:00 AM to 4:00 PM JST
ETA: Friday by 4:00 PM JST

@rogerioduenas rogerioduenas self-requested a review March 14, 2025 05:45
Copy link
Member

@rogerioduenas rogerioduenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jsnhn!

Great job with this pull request!

  • The branching was done correctly.
  • Issue number was listed.
  • The PR title is descriptive of the changes.
    Note: You could replace info with the project name, home-united, next time you submit a PR. The name would be: remove-profile-home-united-7475. No need to change this one.
  • Changes were made correctly in the code.
  • Changes appear correctly on the site - Raji Pradheap was Removed from Home United Us page.
  • Relevant images were included to show visual changes.
  • The PR request clearly states what was updated.

Again, great work and thanks for taking the time to contribute to the website!

@lc1715
Copy link
Member

lc1715 commented Mar 15, 2025

Review ETA: 9PM 3/14/25
Availability: 4-9 PM PST Mon-Fri

Copy link
Member

@lc1715 lc1715 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jsnhn Great job on your good first issue!

  • The PR was done with the correct branch and linked issue
  • The profile for Raji Pradheap was removed from the _projects/home-unite-us.md file.
  • The correct changes can be seen in the browser and source code looks good

Also, just a reminder to check off all Action Items and post your availability and ETA in the linked issue

@github-project-automation github-project-automation bot moved this from PR Needs review to PRs ✅ waiting for merge team in P: HfLA Website: Project Board Mar 15, 2025
@nchanyal nchanyal self-requested a review March 15, 2025 16:37
@nchanyal
Copy link
Member

Review ETA: 1:45 PM EST 3/15/25
Availability: 11 - 1:30 PM EST Mon - Fri

Copy link
Member

@nchanyal nchanyal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @jsnhn! The changes you made follow the ABCs, so they're good to merge!

Thank you for taking up this issue!

@siyunfeng
Copy link
Member

@jsnhn , thank you for working on this issue.

Things to improve:

  • Check all the boxes from the original issue if you have followed all the steps in the instructions
  • Provide your availability and ETA in the original issue comment in the future, so that developers will know about your schedule

@siyunfeng siyunfeng merged commit 68b40f4 into hackforla:gh-pages Mar 17, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe

Projects

Development

Successfully merging this pull request may close these issues.

Update Project Profile: Home Unite Us Remove Raji Pradheap

5 participants