-
-
Notifications
You must be signed in to change notification settings - Fork 844
Update Project Profile: Home Unite Us Remove Raji Pradheap #7989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
Availability: Monday - Friday, 10:00 AM to 4:00 PM JST |
rogerioduenas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jsnhn!
Great job with this pull request!
- The branching was done correctly.
- Issue number was listed.
- The PR title is descriptive of the changes.
Note: You could replaceinfowith the project name,home-united, next time you submit a PR. The name would be:remove-profile-home-united-7475. No need to change this one. - Changes were made correctly in the code.
- Changes appear correctly on the site - Raji Pradheap was Removed from Home United Us page.
- Relevant images were included to show visual changes.
- The PR request clearly states what was updated.
Again, great work and thanks for taking the time to contribute to the website!
|
Review ETA: 9PM 3/14/25 |
lc1715
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jsnhn Great job on your good first issue!
- The PR was done with the correct branch and linked issue
- The profile for Raji Pradheap was removed from the
_projects/home-unite-us.mdfile. - The correct changes can be seen in the browser and source code looks good
Also, just a reminder to check off all Action Items and post your availability and ETA in the linked issue
|
Review ETA: 1:45 PM EST 3/15/25 |
nchanyal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @jsnhn! The changes you made follow the ABCs, so they're good to merge!
Thank you for taking up this issue!
|
@jsnhn , thank you for working on this issue. Things to improve:
|
Fixes #7475
What changes did you make?
Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Visuals before changes are applied
Visuals after changes are applied