Removed Alex Lee from the VRMS markdown #8020
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-project-automation
bot
moved this to PR Needs review
in P: HfLA Website: Project Board
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
github-actions
bot
added
good first issue
Member
|
ETA: EOD 4/2/2025 |
kdaca19xx
approved these changes
Apr 2, 2025
Member
kdaca19xx
left a comment
kdaca19xx
left a comment
There was a problem hiding this comment.
Things Done Well
- The pull request was done with the correct branch.
- Yes, there is a linked issue, and I understood it.
- I looked at the "Files changed" tab.
- The changes were viewable at
localhost:4000/projects/vrms.
Suggested Changes
I don't have any suggested changes. Great job, Melissa!
xnealcarson
approved these changes
Apr 2, 2025
Member
xnealcarson
left a comment
xnealcarson
left a comment
There was a problem hiding this comment.
Things Done Well
- The issue has the correct 'commit into': "hackforla:gh-pages".
- the commit from and collaborator names match.
- The linked issue is present: 'Fixes #7470'.
- The changes made are applicable and clean.
Awesome job on your good first issue, Melissa!
github-project-automation
bot
moved this from PR Needs review
to PRs ✅ waiting for merge team
in P: HfLA Website: Project Board
Member
|
Nice one!
I have verified the changes are accurate and will now merge. 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7470
What changes did you make?
Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Visuals before changes are applied
Visuals after changes are applied