Skip to content

Conversation

@t-will-gillis
Copy link
Member

@t-will-gillis t-will-gillis commented Apr 2, 2025

Fixes #7535

What changes did you make?

  • Using labelKeys to retrieve current labelNames from directory
  • Consolidated the EXCEPTION_LABELS, REQUIRED_ROLE_LABELS, REQUIRED_COMPLEXITY_LABELS with new label assignments
  • Changed status field designations to HARD_CODED
  • Fixed an existing error where the specified status was incorrect 'In Progress' --> 'In progress (actively working' actual

Why did you make the changes (we will use this info to test)?

  • Refactoring the label assignments so that other HfLA groups can use workflows also
  • Also, this allows us to change the label name without worrying about code crashing

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Notes for Reviewers- Testing

If you want to do your own testing for this issue, you probably want to limit the scope of your tests because this automation covers many different scenarios. To proceeed, you will need to set up your environment first:

  • Refer to Hack for LA's GitHub Actions (current revision), especially Tips 6, 7, and 8, if you have not already created your personal environment for testing.
  • Follow the instructions for installing HfLA labels to your repo by following jphamtv 's instructions on the command line, OR in your own repo, enter the relevant labels manually.
  • 1 How to Test GitHub Actions
  • 2 Additional Notes for GitHub Actions
  • Go to preliminary-update-comment.js and find the line for const isAdminOrMerge = await... and replace with:
      // const isAdminOrMerge = await memberOfAdminOrMergeTeam();
      const isAdminOrMerge = false;
    
  • Go to get-timeline.js, find line owner: context.repo.owner, and replace with whatever your GitHub handle is. For me it looks like this: owner: 't-will-gillis', Notice that your handle needs to be in quotes, and include the comma at the end.
  • Your test will not change issue statuses, and the workflow will fail in this step. But you should be able to see that the main steps are being completed.
  • If you would like more info, or if you are getting an error that makes no sense, please contact me.

@github-actions
Copy link

github-actions bot commented Apr 2, 2025

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b t-will-gillis-refactor-check-complex-eligibility-7535 gh-pages
git pull https://github.com/t-will-gillis/website.git refactor-check-complex-eligibility-7535

@github-actions github-actions bot added role: back end/devOps Tasks for back-end developers Complexity: Large size: 5pt Can be done in 19-30 hours 2 weeks inactive Lang: GHA GitHub Actions Skill: enhance labels Apr 2, 2025
@gmgonzal gmgonzal self-requested a review April 4, 2025 01:03
@gmgonzal
Copy link
Member

gmgonzal commented Apr 4, 2025

Review ETA: 4/8


// Add 'Status: Unassigned by Bot' label
await github.rest.issues.addLabels({
owner,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • use new var for 'Status: Unassigned by Bot' on line 372

Copy link
Member

@gmgonzal gmgonzal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @t-will-gillis , code changes look good! There are some minor edits I suggest we should make, let me know what you think.

I will try to validate the changes on my end. Will update by tomorrow latest (4/10).

Thanks!

Copy link
Member

@gmgonzal gmgonzal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@t-will-gillis after some hacking, I was able to validate the action on my end. Approved!

Test issue
Passing Action

@t-will-gillis t-will-gillis merged commit c7e7c0d into hackforla:gh-pages Apr 15, 2025
15 checks passed
@t-will-gillis t-will-gillis deleted the refactor-check-complex-eligibility-7535 branch April 15, 2025 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complexity: Large Lang: GHA GitHub Actions role: back end/devOps Tasks for back-end developers size: 5pt Can be done in 19-30 hours Skill: enhance

Projects

Development

Successfully merging this pull request may close these issues.

Enhance GHA check-complexity-eligibility.js to use label-directory.json

2 participants