-
-
Notifications
You must be signed in to change notification settings - Fork 844
Enhance GHA check-complexity-eligibility.js to use label-directory.json
#8037
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance GHA check-complexity-eligibility.js to use label-directory.json
#8037
Conversation
For testing, set `isAdminOrMerge` to false
Change incorrect `complexityPrework` --> `complexity0`
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
Review ETA: 4/8 |
|
|
||
| // Add 'Status: Unassigned by Bot' label | ||
| await github.rest.issues.addLabels({ | ||
| owner, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- use new var for 'Status: Unassigned by Bot' on line 372
github-actions/trigger-issue/add-preliminary-comment/check-complexity-eligibility.js
Show resolved
Hide resolved
github-actions/trigger-issue/add-preliminary-comment/check-complexity-eligibility.js
Show resolved
Hide resolved
gmgonzal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @t-will-gillis , code changes look good! There are some minor edits I suggest we should make, let me know what you think.
I will try to validate the changes on my end. Will update by tomorrow latest (4/10).
Thanks!
gmgonzal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@t-will-gillis after some hacking, I was able to validate the action on my end. Approved!
Fixes #7535
What changes did you make?
EXCEPTION_LABELS,REQUIRED_ROLE_LABELS,REQUIRED_COMPLEXITY_LABELSwith new label assignmentsWhy did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Notes for Reviewers- Testing
If you want to do your own testing for this issue, you probably want to limit the scope of your tests because this automation covers many different scenarios. To proceeed, you will need to set up your environment first:
const isAdminOrMerge = await...and replace with:owner: context.repo.owner,and replace with whatever your GitHub handle is. For me it looks like this:owner: 't-will-gillis',Notice that your handle needs to be in quotes, and include the comma at the end.