-
-
Notifications
You must be signed in to change notification settings - Fork 844
Update Project Profile: Home Unite Us Remove Jed Stewart #8041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Project Profile: Home Unite Us Remove Jed Stewart #8041
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
ETA: EOD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @melissaluc
Thank you for taking this issue. You're contribution is greatly appreciated.
Things That Done Well
- Your PR contains the correct branch.
- You successfully linked your issue.
- The PR title is informative, as are both the what and why for its changes in the contents.
- The Source Code changes you committed look awesome.
- You successfully completed your task.
The only thing I would request is making the before a after images a little bigger. It's hard to see the changes you made to the website.
But, besides that, you did a fantastic job on this issue, and I will approve it!
Great job Melissa!
|
Review ETA: EOD 4/6/25 |
lc1715
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @melissaluc, thank you for contributing! Your PR is done with the correct branch, linked issue, and you did a great job completing and checking off all of the requirements in the issue!
Some things to change:
-
Please delete this message at the top of your PR
Please note: You must be a member of the HFLA website team in order to create pull requests. Please see our page on how to join us as a member at HFLA: https://www.hackforla.org/getting-started. Delete this message if you joined this team via onboarding. -
Please check off the appropriate checkbox for the CodeQL alerts

Also, for the future, consider making the branch names more descriptive. For example you can add the project name (homeuniteus) and name of profile that you're removing (remove-Jed-Stewart) to the branch name as well. But no need to change this current branch name.
|
@melissaluc, thank you for making the changes! Great job! |
Christopher-Chhim
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correctly removed Jed Stewart's information from the website while keeping it user friendly. Great job Melissa!
|
Hey @melissaluc! Thank you for taking on this issue. Things Done Well
Keep up the great work! |
|
Great work @melissaluc! For the PR title, please remove the issue number and be more descriptive such as Update Project Profile: Home Unite Us Remove Jed Stewart. If you need help with anything, feel free to reach out. Thanks. |
|
Review ETA: 12 Apr 2025 @ 6 PM (BST) |
mugdhchauhan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @melissaluc, thanks for working on this.
- PR is done with the correct branch.
- PR title has been updated.
- PR post contains a linked issue, what changes you made and why are clear, CodeQL alerts have been checked, and before and after screenshots are provided.
The changes to the_projects/home-unite-us.mdfile are accurate. - I have viewed the changes in the browser in multiple viewports and checked that it is good.
Great job. Thanks for working with the reviewers to make the changes. I approve this PR. 👍
|
Nice one! Thanks for working on this. I have verified the changes are accurate and will now merge. 🎉 |
Fixes #7485
What changes did you make?
Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Visuals before changes are applied
Visuals after changes are applied