Skip to content

Conversation

@melissaluc
Copy link
Member

@melissaluc melissaluc commented Apr 3, 2025

Fixes #7485

What changes did you make?

  • Removed Jed Stewart from the Current Project Team from project Home United Us

Why did you make the changes (we will use this info to test)?

  • To keep project information up to date

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied

before

Visuals after changes are applied

after

@github-actions
Copy link

github-actions bot commented Apr 3, 2025

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b melissaluc-update-project-profile-7485 gh-pages
git pull https://github.com/melissaluc/website.git update-project-profile-7485

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe size: 0.25pt Can be done in 0.5 to 1.5 hours labels Apr 3, 2025
@dvernon5 dvernon5 self-requested a review April 4, 2025 05:21
@dvernon5
Copy link
Member

dvernon5 commented Apr 4, 2025

ETA: EOD
Availability: Monday-Thursday 2PM - 6PM and Friday 2PM - 4PM

Copy link
Member

@dvernon5 dvernon5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @melissaluc

Thank you for taking this issue. You're contribution is greatly appreciated.

Things That Done Well

  • Your PR contains the correct branch.
  • You successfully linked your issue.
  • The PR title is informative, as are both the what and why for its changes in the contents.
  • The Source Code changes you committed look awesome.
  • You successfully completed your task.

The only thing I would request is making the before a after images a little bigger. It's hard to see the changes you made to the website.

But, besides that, you did a fantastic job on this issue, and I will approve it!

Great job Melissa!

@lc1715 lc1715 self-requested a review April 6, 2025 09:48
@lc1715
Copy link
Member

lc1715 commented Apr 6, 2025

Review ETA: EOD 4/6/25
Availability: 3-9 PM Mon-Fri

Copy link
Member

@lc1715 lc1715 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @melissaluc, thank you for contributing! Your PR is done with the correct branch, linked issue, and you did a great job completing and checking off all of the requirements in the issue!

Some things to change:

  • Please delete this message at the top of your PR
    Please note: You must be a member of the HFLA website team in order to create pull requests. Please see our page on how to join us as a member at HFLA: https://www.hackforla.org/getting-started. Delete this message if you joined this team via onboarding.

  • Please check off the appropriate checkbox for the CodeQL alerts
    image

Also, for the future, consider making the branch names more descriptive. For example you can add the project name (homeuniteus) and name of profile that you're removing (remove-Jed-Stewart) to the branch name as well. But no need to change this current branch name.

@github-project-automation github-project-automation bot moved this from PR Needs review to PRs being reviewed in P: HfLA Website: Project Board Apr 6, 2025
@melissaluc melissaluc requested a review from lc1715 April 8, 2025 20:13
@github-project-automation github-project-automation bot moved this from PRs being reviewed to PRs ✅ waiting for merge team in P: HfLA Website: Project Board Apr 9, 2025
@lc1715
Copy link
Member

lc1715 commented Apr 9, 2025

@melissaluc, thank you for making the changes! Great job!

Copy link
Member

@Christopher-Chhim Christopher-Chhim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correctly removed Jed Stewart's information from the website while keeping it user friendly. Great job Melissa!

@Christopher-Chhim
Copy link
Member

Hey @melissaluc! Thank you for taking on this issue.

Things Done Well

  • Your changes are made in the right branch
  • Your changes accurately reflect the issue you're addressing
  • Code doesn't interfere with anything else.
  • PR is well-written
  • Passed all CodeQL alerts

Keep up the great work!

@mugdhchauhan
Copy link
Member

Great work @melissaluc! For the PR title, please remove the issue number and be more descriptive such as Update Project Profile: Home Unite Us Remove Jed Stewart.

If you need help with anything, feel free to reach out. Thanks.

@melissaluc melissaluc changed the title Update project profile 7485 Update Project Profile: Home Unite Us Remove Jed Stewart Apr 11, 2025
@melissaluc melissaluc requested a review from mugdhchauhan April 11, 2025 22:02
@mugdhchauhan
Copy link
Member

Review ETA: 12 Apr 2025 @ 6 PM (BST)
Availability: Daily @ 6 PM - 8 PM (BST)

Copy link
Member

@mugdhchauhan mugdhchauhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @melissaluc, thanks for working on this.

  • PR is done with the correct branch.
  • PR title has been updated.
  • PR post contains a linked issue, what changes you made and why are clear, CodeQL alerts have been checked, and before and after screenshots are provided.
    The changes to the _projects/home-unite-us.md file are accurate.
  • I have viewed the changes in the browser in multiple viewports and checked that it is good.

Great job. Thanks for working with the reviewers to make the changes. I approve this PR. 👍

@mugdhchauhan
Copy link
Member

Nice one! Thanks for working on this. I have verified the changes are accurate and will now merge. 🎉

@mugdhchauhan mugdhchauhan merged commit 2e82dd2 into hackforla:gh-pages Apr 12, 2025
17 checks passed
@andyvu923 andyvu923 mentioned this pull request Apr 18, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe

Projects

Development

Successfully merging this pull request may close these issues.

Update Project Profile: Home Unite Us Remove Jed Stewart

6 participants