Update Project Profile: VRMS New GitHub handle and role of Trillium Smith #8046

valdezg · 2025-04-05T20:39:52Z

What changes did you make?

Added Trillium Smith / changed to lead developer
updated picture
updated github handle

Why did you make the changes (we will use this info to test)?

To work on my first issue
change profile picture
change role name from developer to lead developer

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

I have checked this PR for CodeQL alerts and none were found.
I found CodeQL alert(s), and (select one):
- I have resolved the CodeQL alert(s) as noted
- I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
- I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)

Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied

Visuals after changes are applied

github-actions · 2025-04-05T20:40:16Z

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b valdezg-update-trillium-7879 gh-pages
git pull https://github.com/valdezg/website.git update-trillium-7879

DrAcula27

Hi @valdezg,
Great start on your Good First Issue!

What you did well:

Fixed and linked to the correct issue #7879
Succinctly answered the questions at the top of the PR.
Correctly replaced the text within the _projects/vrms.md file.

What needs work:

In the CodeQL Alerts section of the PR:
- Please check the relevant checkbox(s) answering whether you got any CodeQL alerts when you made the PR.
In the Screenshots of Proposed Changes To The Website section of the PR:
- Please follow the instructions in the Notes comment to add a picture of the before and after changes to the website. If there were no visual changes, please delete the script and add 'No visual changes to the website'.
In the next website meeting, please bring up why you had to add the vrms.md file. If this was necessary, and I am missing the reason, feel free to let me know!

Great job so far, you got this!

kdaca19xx · 2025-04-09T02:39:24Z

Review ETA: 6 PM 4/12/2025
Availability: after 12noon Saturday

katiejnete · 2025-04-10T03:00:23Z

Review ETA: EOD 4/9/25
Availability: Wednesday Nights

katiejnete

Hi @valdezg , good job on your first GFI. Thank you for taking on this issue.

Things you did well:

PR is done with the correct branch.
PR contains correctly formatted linked issue.
PR follows correct format and is properly written.
The changes are applicable to the issue.
Website is still user-friendly and links and components still work as intended.

Suggested changes:

Please check the proper CodeQL Alerts checkbox.
Please make sure the before and after screenshots are appropriately included. Please remove what you have, drag/drop images, and wait for them to properly render.
You have created a duplicate file in the root website directory vrms.md. Please delete this file.

Notes:

Your issue branch name could include more detail update-project-profile-trillium-smith-7879. No need to change it for this issue.

After making these changes, re-request a review from me. Thank you for your hard work!

deleting manual file change

deleting duplicate branch

valdezg

deleting duplicate branch

valdezg · 2025-04-10T03:28:48Z

Added before and after pictures in comment. I also deleted a branch that was a duplicate and removed a file that I accidentaly added by mistake. Please let me know if this is ok for now. Thanks everyone!

katiejnete · 2025-04-10T03:51:11Z

Hi @valdezg , the wrong file was deleted. Please keep the file vrms.md in the_projects directory but remove the vrms.md file from the root directory, website. For the CodeQL Alerts checkboxes, the first checkbox will suffice since none were found.

After making these changes, re-request a review from me. Thank you for your hard work!

valdezg

need to restore this file

valdezg · 2025-04-10T04:54:01Z

hi @katiejnete I tried removing one of the branches but I am not sure how to restore the file after deleting it. Is there anyway to do this without re doing the entire commit? Sorry for the confusion.

katiejnete · 2025-04-10T05:11:12Z

Hi @valdezg , you can try this git revert <oldest_commit_hash>^..<latest_commit_hash> (git revert abc123^..def456 ). It's inclusive, and you may or may not have to resolve merge conflicts. After reverting, you can push like normal.

kdaca19xx

Strong effort, Valdezg!

Things Done Well

The pull request was done with the correct branch.
There is a linked issue.
I understood the linked issue.
I'm stating the obvious by now, but I couldn't look at the file in the Files changed tab (or on valdezg's branch in VS Code), and I couldn't view changes in the browser via Docker Desktop (Screenshots taken).

Suggestions

Please see what others advised in the comments above.

valdezg · 2025-04-11T04:51:12Z

Okay thanks everyone for taking a look. I basically had to go back and redo everything. I used git revert and was able to restore the missing file since I accidentally deleted it on githubs website. Please let me know if the branch looks better now and I am adding through the correct method.

DrAcula27

@valdezg Much better! This looks good to me now. Approved 👍

katiejnete

Thank you for your hard work @valdezg , I approve this PR.

kdaca19xx · 2025-04-13T17:30:44Z

Thx for making those changes, @valdezg. Approved!

mugdhchauhan · 2025-04-13T23:41:14Z

Nice one @valdezg! Thank you for working on this and making the changes requested by the reviewers.

For the PR title, please could you remove the issue number and make it more descriptive such as Update Project Profile: VRMS New GitHub handle and role of Trillium Smith. Thanks.

mugdhchauhan · 2025-04-13T23:52:43Z

Hey @kdaca19xx, thank you for re-reviewing.

Please review by going to the "Files changed" tab, clicking on the green "Review changes" button, completing the appropriate sections, and finally pressing the "Submit review" button. The screenshot below may be helpful.

Screenshot

Feel free to reach out to me if you need help with anything. Thank you for working on this.

valdezg · 2025-04-15T23:50:09Z

Hi @mugdhchauhan. I just updated the title of the PR! Thanks let me know if you need any more changes. Best

kdaca19xx

Approved!

valdezg and others added 3 commits April 4, 2025 12:57

Add files via upload

ee5c567

trillium change

2442a4c

trillium changes

9a84c18

github-project-automation bot moved this to PR Needs review in P: HfLA Website: Project Board Apr 5, 2025

github-project-automation bot added this to P: HfLA Website: Project Board Apr 5, 2025

DrAcula27 self-requested a review April 7, 2025 22:11

DrAcula27 suggested changes Apr 7, 2025

View reviewed changes

github-project-automation bot moved this from PR Needs review to PRs being reviewed in P: HfLA Website: Project Board Apr 7, 2025

daras-cu requested a review from kdaca19xx April 9, 2025 02:35

katiejnete suggested changes Apr 10, 2025

View reviewed changes

valdezg added 2 commits April 9, 2025 20:12

Delete vrms.md

295aead

deleting manual file change

Delete _projects/vrms.md

5ed5a4d

deleting duplicate branch

valdezg commented Apr 10, 2025

View reviewed changes

valdezg requested review from DrAcula27 and katiejnete April 10, 2025 03:29

valdezg commented Apr 10, 2025

View reviewed changes

Merge branch 'hackforla:gh-pages' into update-trillium-7879

2362346

kdaca19xx reviewed Apr 11, 2025

View reviewed changes

valdezg added 4 commits April 10, 2025 20:50

Merge branch 'hackforla:gh-pages' into update-trillium-7879

e31a82f

changed the trillium file

e2dbf3e

changed the trillium file

47c1616

restored file by adding it through older commits

4a19f2d

valdezg requested a review from kdaca19xx April 11, 2025 04:51

DrAcula27 approved these changes Apr 12, 2025

View reviewed changes

katiejnete approved these changes Apr 12, 2025

View reviewed changes

github-project-automation bot moved this from PRs being reviewed to PRs ✅ waiting for merge team in P: HfLA Website: Project Board Apr 12, 2025

priyanka02art mentioned this pull request Apr 13, 2025

EPIC: Prepare the Project Pages page for Homepage Launch #7679

Open

39 tasks

valdezg changed the title ~~Update trillium 7879~~ Update Project Profile: VRMS New GitHub handle and role of Trillium Smith Apr 15, 2025

kdaca19xx approved these changes Apr 16, 2025

View reviewed changes

daras-cu merged commit 7fd1651 into hackforla:gh-pages Apr 16, 2025
5 checks passed

DrAcula27 mentioned this pull request May 1, 2025

Review Inactive Team Members #8105

Closed

valdezg mentioned this pull request May 8, 2025

Update Project Profile Remove User 8070 #8092

Closed

5 tasks

valdezg deleted the update-trillium-7879 branch May 18, 2025 04:56

kdaca19xx mentioned this pull request May 31, 2025

Skills Issue: Developer: [Kerstin Carson] #7971

Open

This was referenced Aug 10, 2025

Pre-work Checklist: Developer: Danielle Andrews #6598

Closed

Skills Issue: Developer: Kate Vong #7695

Closed

Skills Issue: Developer: German Valdez #7886

Closed

Skills Issue: Developer: Mugdh Chauhan #7698

Closed

t-will-gillis mentioned this pull request Aug 22, 2025

Skills Issue: Developer: Danielle Aras #6948

Open

31 tasks

myronchen-git mentioned this pull request Nov 7, 2025

Add github-handle for Trillium Smith in vrms.md #7357

Closed

5 tasks

Uh oh!

Update Project Profile: VRMS New GitHub handle and role of Trillium Smith #8046

Update Project Profile: VRMS New GitHub handle and role of Trillium Smith #8046

Uh oh!

Conversation

valdezg commented Apr 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What changes did you make?

Why did you make the changes (we will use this info to test)?

CodeQL Alerts

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Uh oh!

github-actions bot commented Apr 5, 2025

Uh oh!

DrAcula27 left a comment

Choose a reason for hiding this comment

Uh oh!

kdaca19xx commented Apr 9, 2025

Uh oh!

katiejnete commented Apr 10, 2025

Uh oh!

katiejnete left a comment • edited by valdezg Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Things you did well:

Suggested changes:

Uh oh!

valdezg left a comment

Choose a reason for hiding this comment

Uh oh!

valdezg commented Apr 10, 2025

Uh oh!

katiejnete commented Apr 10, 2025

Uh oh!

valdezg left a comment

Choose a reason for hiding this comment

Uh oh!

valdezg commented Apr 10, 2025

Uh oh!

katiejnete commented Apr 10, 2025

Uh oh!

kdaca19xx left a comment

Choose a reason for hiding this comment

Things Done Well

Suggestions

Uh oh!

valdezg commented Apr 11, 2025

Uh oh!

DrAcula27 left a comment

Choose a reason for hiding this comment

Uh oh!

katiejnete left a comment

Choose a reason for hiding this comment

Uh oh!

kdaca19xx commented Apr 13, 2025

Uh oh!

mugdhchauhan commented Apr 13, 2025

Uh oh!

mugdhchauhan commented Apr 13, 2025

Uh oh!

valdezg commented Apr 15, 2025

Uh oh!

kdaca19xx left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

valdezg commented Apr 5, 2025 •

edited

Loading

katiejnete left a comment •

edited by valdezg

Loading