-
-
Notifications
You must be signed in to change notification settings - Fork 844
Remove PS message in issue trigger #8053
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove PS message in issue trigger #8053
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
Review ETA: 6 PM PDT Thursday, March 10, 2025 |
|
Review ETA: 5 PM PDT Friday, April 11, 2025 |
Six5pAdes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problems here, you did exactly what was asked for from the issue.
|
ETA: EOD |
dvernon5
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @Khinememe-Kyaw
Great work on your PR! You've completed all tasks, linked the PR to the correct branch, and provided a clear, concise issue explanation. The PR title is also well-crafted.
One small suggestion: since no website changes were made, you can remove the images from the PR. Once those are removed, re-request my review, and I'll approve it from there.
Once again, awesome job!
|
@dvernon5 Thank you! I deleted the images |
dvernon5
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for making the following changes. Everything looks great now!
Once again, great job on your PR!
DDVVPP
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @Khinememe-Kyaw !
- The PR title and branch name are clear
- Action items in issue were checked off
- The changed file looks correctly updated
|
Nice one @Khinememe-Kyaw! Thanks for working on this. I have verified the changes are accurate and will now merge. 🎉 |
Fixes #7941
What changes did you make?
Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging