Skip to content

Conversation

@gabbyjimenez
Copy link
Member

@gabbyjimenez gabbyjimenez commented Oct 8, 2025

Fixes #8117

What changes did you make?

  • Removed Sylvia Nam from the leadership section on the Expunge Assist webpage

Why did you make the changes (we will use this info to test)?

  • To keep project information up to date so that visitors to the website can find accurate information

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied

image

image
Visuals after changes are applied

image

image

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe size: 0.25pt Can be done in 0.5 to 1.5 hours labels Oct 8, 2025
Copy link
Member

@myronchen-git myronchen-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work on completing this issue.


Done Correctly

  • The merge from and to branches have been correctly set.
  • The issue has been correctly linked.
  • The pull request title is named properly.
  • The whats and whys in the pull request description is well written.
  • The CodeQL alerts have been correctly checked off.
  • Screenshots accurately reflect before and after changes.
  • Code changes have been correctly made.
  • In the issue, action items are checked off.

Other Notes

  • On the issue, availability and ETA were not given. These help to inform other team members of your status. It is not necessary to put those now, since the work is done now.

@santiseccovidal santiseccovidal self-requested a review October 9, 2025 21:08
Copy link
Member

@santiseccovidal santiseccovidal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @gabbyjimenez everything look correct. Branches, why & what sections, the changes running locally are as expected.
Thanks for picking up this issue

@github-project-automation github-project-automation bot moved this from PR Needs review to PRs ✅ waiting for merge team in P: HfLA Website: Project Board Oct 9, 2025
@santiseccovidal santiseccovidal merged commit 074ddb4 into hackforla:gh-pages Oct 9, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe

Projects

Development

Successfully merging this pull request may close these issues.

Update Project Profile: Expunge Assist - Remove Sylvia Nam

3 participants