Add wrapper_attr attribute to #derive(Semantics) #607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
The whole semantics part is going to change a lot so I’m not quite sure this is something that is going to work afterwards. Let me have a look at whether we can merge it first and then I will start the refactoring, or the other way around. |
Allows adding attributes to the wrapper structs, in particular derive. For example, allows the wrappers to derive bytemuck::Pod. Also add #[repr(transparent)] to the wrappers, since there's no reason not to and should probably have them anyway for safety.
ColonelThirtyTwo
force-pushed
the
semantics-wrappers-attrs
branch
from
a8c8282 to
7edc281
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows adding attributes to the wrapper structs, in particular derive.
For example, allows the wrappers to derive bytemuck::Pod.
Also add #[repr(transparent)] to the wrappers, since there's no reason
not to and should probably have them anyway for safety.