Skip to content

BWebPage's createNewPage method now requires a BUrlContext #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pulkomandy merged 2 commits into from
Sep 25, 2022
Merged

BWebPage's createNewPage method now requires a BUrlContext #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
45e6714
BWebPage's createNewPage method now requires a BUrlContext
jsteinaker Sep 24, 2022
45f6c2f
Restore blank line
jsteinaker Sep 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Source/WebKitLegacy/haiku/API/WebPage.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -635,10 +635,10 @@ WebCore::Page* BWebPage::page() const
}

WebCore::Page* BWebPage::createNewPage(BRect frame, bool modalDialog,
bool resizable, bool activate)
bool resizable, bool activate, BPrivate::Network::BUrlContext* context)
{
// Creating the BWebView in the application thread is exactly what we need anyway.
BWebView* view = new BWebView("web view");
BWebView* view = new BWebView("web view", context);
BWebPage* page = view->WebPage();

BMessage message(NEW_PAGE_CREATED);
Expand Down
2 changes: 1 addition & 1 deletion Source/WebKitLegacy/haiku/API/WebPage.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ class __attribute__ ((visibility ("default"))) BWebPage : private BHandler {

WebCore::Page* createNewPage(BRect frame = BRect(),
bool modalDialog = false, bool resizable = true,
bool activate = true);
bool activate = true, BPrivate::Network::BUrlContext* context = nullptr);

BPrivate::Network::BUrlContext* GetContext();
BRect windowFrame();
Expand Down
3 changes: 2 additions & 1 deletion Source/WebKitLegacy/haiku/WebCoreSupport/ChromeClientHaiku.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,8 @@ Page* ChromeClientHaiku::createWindow(Frame& /*frame*/, const WindowFeatures& fe
if (features.height)
windowFrame.bottom = windowFrame.top + *features.height - 1;

WebCore::Page* page = m_webPage->createNewPage(windowFrame, features.dialog, features.resizable);
WebCore::Page* page = m_webPage->createNewPage(windowFrame, features.dialog,
features.resizable, true, m_webPage->GetContext());
if (!page)
return 0;

Expand Down