ImageBuffer: sync view on image copy #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pulkomandy
pushed a commit
that referenced
this pull request
Apr 12, 2025
…rtions https://bugs.webkit.org/show_bug.cgi?id=291090 rdar://148601073 Reviewed by Yusuke Suzuki. This patch enhances loop unrolling debugging by adding support for tracking the original source block (cloneSource) for each cloned basic block in DFGBasicBlock. The cloneSource pointer is enabled only under ASSERT_ENABLED to avoid runtime overhead in release builds. Additionally, Graph::dumpBlockHeader() now prints the clone source block if available, improving traceability during debugging and validation of loop unrolling logic. After loop unrolling, we might see output like the following, where block 17 is a clone of block 9: 9 24: Block #9 (bc#52): 0 9 24: D@62:<!0:-> LoopHint(MustGen, W:SideState, bc#52, ExitValid) ... 17 24: Block #17<-#9 (bc#52): 0 17 24: D@256:<!0:-> LoopHint(MustGen, W:SideState, bc#52, ExitValid) ... * Source/JavaScriptCore/dfg/DFGBasicBlock.h: * Source/JavaScriptCore/dfg/DFGGraph.cpp: (JSC::DFG::Graph::dumpBlockHeader): * Source/JavaScriptCore/dfg/DFGLoopUnrollingPhase.cpp: (JSC::DFG::LoopUnrollingPhase::unrollLoop): Canonical link: https://commits.webkit.org/293265@main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brings back the gradient for not-hovered items in the menu bar in https://dev.haiku-os.org/.
Bisecting pointed to 5726cb7, where copyImage is devirtualized and calls copyNativeImage, so we lost our Sync. I don't know whether that is needed for both doCopy cases (putting it in the DontCopyBackingStore route seems to be enough) and why it wasn't needed before there.