feat: working plugin scope for nixvim and lazy #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
The plugin scope is amazing :D I had to change a few things 06a3d6f to have it working with lazy and for the actions to exist until they are merged in community. Hopefully it makes sense. If so, happy to merge it. |
fidgetingbits
commented
Jul 19, 2024
fidgetingbits
commented
Jul 19, 2024
|
Just fixed up #5 to also match the func signature changes too. I'm okay with your changes, so you can merge whenever |
saidelike
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #12 and invalidates PR #11 as I updated the context match, and also updated the action names to match #5 naming.
I've tested it on both nixvim and with lazy.nvim. I've put skeletons in for a few other common package managers, but haven't implemented them yet as it's not a priority. I'll file an issue to do it later.
Not sure what the difference is between our talonfmt config in vscode that caused the lazy.talon whitespace changes, but I can remove that hunk if you find it annoying.