Skip to content

Commit 01367d5

Browse files
Updates flutter_localizations/test to stop using TestWindow (flutter#122321)
Updates `flutter_localizations/test` to stop using `TestWindow`
1 parent c2a5111 commit 01367d5

File tree

2 files changed

+9
-14
lines changed

2 files changed

+9
-14
lines changed

packages/flutter_localizations/test/material/date_picker_test.dart

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -227,10 +227,9 @@ void main() {
227227
const Size kCommonScreenSizeLandscape = Size(1770, 1070);
228228

229229
Future<void> showPicker(WidgetTester tester, Locale locale, Size size) async {
230-
tester.binding.window.physicalSizeTestValue = size;
231-
addTearDown(tester.binding.window.clearPhysicalSizeTestValue);
232-
tester.binding.window.devicePixelRatioTestValue = 1.0;
233-
addTearDown(tester.binding.window.clearDevicePixelRatioTestValue);
230+
tester.view.physicalSize = size;
231+
tester.view.devicePixelRatio = 1.0;
232+
addTearDown(tester.view.reset);
234233
await tester.pumpWidget(
235234
MaterialApp(
236235
home: Builder(

packages/flutter_localizations/test/material/time_picker_test.dart

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,9 @@ import 'package:flutter_test/flutter_test.dart';
99
void main() {
1010
testWidgets('can localize the header in all known formats - portrait', (WidgetTester tester) async {
1111
// Ensure picker is displayed in portrait mode.
12-
tester.binding.window.physicalSizeTestValue = const Size(400, 800);
13-
tester.binding.window.devicePixelRatioTestValue = 1;
12+
tester.view.physicalSize = const Size(400, 800);
13+
tester.view.devicePixelRatio = 1;
14+
addTearDown(tester.view.reset);
1415

1516
final Finder stringFragmentTextFinder = find.descendant(
1617
of: find.byWidgetPredicate((Widget w) => '${w.runtimeType}' == '_StringFragment'),
@@ -74,15 +75,13 @@ void main() {
7475
await tester.tapAt(Offset(center.dx, center.dy - 50.0));
7576
await finishPicker(tester);
7677
}
77-
78-
tester.binding.window.clearPhysicalSizeTestValue();
79-
tester.binding.window.clearDevicePixelRatioTestValue();
8078
});
8179

8280
testWidgets('can localize the header in all known formats - landscape', (WidgetTester tester) async {
8381
// Ensure picker is displayed in landscape mode.
84-
tester.binding.window.physicalSizeTestValue = const Size(800, 400);
85-
tester.binding.window.devicePixelRatioTestValue = 1;
82+
tester.view.physicalSize = const Size(800, 400);
83+
tester.view.devicePixelRatio = 1;
84+
addTearDown(tester.view.reset);
8685

8786
final Finder stringFragmentTextFinder = find.descendant(
8887
of: find.byWidgetPredicate((Widget w) => '${w.runtimeType}' == '_StringFragment'),
@@ -151,9 +150,6 @@ void main() {
151150
await tester.tapAt(Offset(center.dx, center.dy - 50.0));
152151
await finishPicker(tester);
153152
}
154-
155-
tester.binding.window.clearPhysicalSizeTestValue();
156-
tester.binding.window.clearDevicePixelRatioTestValue();
157153
});
158154

159155
testWidgets('can localize input mode in all known formats', (WidgetTester tester) async {

0 commit comments

Comments
 (0)