Skip to content

Updates flutter_localizations/test to stop using TestWindow #122321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 9, 2023
Merged

Updates flutter_localizations/test to stop using TestWindow #122321

merged 1 commit into from
Mar 9, 2023

Conversation

pdblasi-google
Copy link
Contributor

@pdblasi-google pdblasi-google commented Mar 9, 2023 •
edited
Loading

Updates flutter_localizations/test to stop using TestWindow.

Resolves #122237.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added a: internationalization Supporting other languages or locales. (aka i18n) f: material design flutter/packages/flutter/material repository. labels Mar 9, 2023
goderbauer
goderbauer approved these changes Mar 9, 2023
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pdblasi-google pdblasi-google added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 9, 2023
@auto-submit auto-submit bot merged commit 01367d5 into flutter:master Mar 9, 2023
@pdblasi-google pdblasi-google deleted the issues/122237 branch March 10, 2023 01:00
@CaseyHillers CaseyHillers mentioned this pull request Mar 10, 2023
Merged
8 tasks
CaseyHillers pushed a commit to CaseyHillers/flutter that referenced this pull request Mar 10, 2023
Revert "Updates flutter_localizations/test to stop using `TestWindo…
46e2f22 
…w` (flutter#122321)"

This reverts commit 01367d5.
CaseyHillers pushed a commit that referenced this pull request Mar 10, 2023
Revert PRs relating to single window assumption (#122369)
1f42612 
* Revert "Remove references to BindingBase.window (#122119)"

This reverts commit c7681f0.

* Revert "Remove another reference to BindingBase.window (#122341)"

This reverts commit 6ec4445.

* Revert "Reland (2): Removes single window assumptions from `flutter_test` (#122233)"

This reverts commit eb3d317.

* Revert "Remove single view assumption from TestViewConfiguration (#122352)"

This reverts commit 927289f.

* Revert "Updates `flutter/test/cupertino` to no longer use `TestWindow` (#122325)"

This reverts commit 67e17e4.

* Revert "Updates `flutter/test/gestures` to no longer reference `TestWindow` (#122327)"

This reverts commit c2a5111.

* Revert "Updates `flutter/test/rendering` to no longer use `TestWindow` (#122347)"

This reverts commit 28b65e0.

* Revert "Updates `flutter_localizations/test` to stop using `TestWindow` (#122321)"

This reverts commit 01367d5.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 10, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 10, 2023
@engine-flutter-autoroll
01367d5 Updates flutter_localizations/test to stop using `TestWindo…
372ec4c 
…w` (flutter/flutter#122321)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 10, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 10, 2023
@engine-flutter-autoroll
01367d5 Updates flutter_localizations/test to stop using `TestWindo…
4f63299 
…w` (flutter/flutter#122321)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 10, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 10, 2023
@engine-flutter-autoroll
01367d5 Updates flutter_localizations/test to stop using `TestWindo…
a24e648 
…w` (flutter/flutter#122321)
hannah-hyj pushed a commit to hannah-hyj/flutter that referenced this pull request Mar 11, 2023
@pdblasi-google @hannah-hyj
Updates flutter_localizations/test to stop using TestWindow (flut…
a0f5494 
…ter#122321)

Updates `flutter_localizations/test` to stop using `TestWindow`
hannah-hyj pushed a commit to hannah-hyj/flutter that referenced this pull request Mar 11, 2023
@hannah-hyj
Revert PRs relating to single window assumption (flutter#122369)
c3a9baa 
* Revert "Remove references to BindingBase.window (flutter#122119)"

This reverts commit c7681f0.

* Revert "Remove another reference to BindingBase.window (flutter#122341)"

This reverts commit 6ec4445.

* Revert "Reland (2): Removes single window assumptions from `flutter_test` (flutter#122233)"

This reverts commit eb3d317.

* Revert "Remove single view assumption from TestViewConfiguration (flutter#122352)"

This reverts commit 927289f.

* Revert "Updates `flutter/test/cupertino` to no longer use `TestWindow` (flutter#122325)"

This reverts commit 67e17e4.

* Revert "Updates `flutter/test/gestures` to no longer reference `TestWindow` (flutter#122327)"

This reverts commit c2a5111.

* Revert "Updates `flutter/test/rendering` to no longer use `TestWindow` (flutter#122347)"

This reverts commit 28b65e0.

* Revert "Updates `flutter_localizations/test` to stop using `TestWindow` (flutter#122321)"

This reverts commit 01367d5.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2023
@engine-flutter-autoroll
01367d5 Updates flutter_localizations/test to stop using `TestWindo…
2dcc919 
…w` (flutter/flutter#122321)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 12, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2023
@engine-flutter-autoroll
01367d5 Updates flutter_localizations/test to stop using `TestWindo…
dcb1e91 
…w` (flutter/flutter#122321)
@HansMuller HansMuller mentioned this pull request Mar 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
01367d5 Updates flutter_localizations/test to stop using `TestWindo…
0c88e8e 
…w` (flutter/flutter#122321)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
01367d5 Updates flutter_localizations/test to stop using `TestWindo…
3baccd0 
…w` (flutter/flutter#122321)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees
No one assigned
Labels
a: internationalization Supporting other languages or locales. (aka i18n) autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update flutter_localizations/test to stop using TestWindow
2 participants
@pdblasi-google @goderbauer