Touch and hold to drag #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakobkolb
suggested changes
Jul 28, 2020
levino
force-pushed
the
feature/issue-24-touch-and-hold-to-drag
branch
from
a3bdf23 to
8083f18
Compare
levino
commented
Jul 29, 2020
| @@ -2,7 +2,6 @@ | |||
| "parser": "@typescript-eslint/parser", | |||
| "extends": [ | |||
| "react-app", | |||
| "plugin:@typescript-eslint/recommended", | |||
There was a problem hiding this comment.
This was too strict. The "react-app" config is strict enough.
levino
commented
Jul 29, 2020
| "react-dnd": "^9.4.0", | ||
| "react-dnd-cjs": "^9.4.0", | ||
| "react-dnd-html5-backend": "^9.4.0", | ||
| "react-dnd-html5-backend-cjs": "^9.4.0", |
There was a problem hiding this comment.
The *-cjs-packages were never imported anywhere. I could not see a reason to keep them. Hope this does not break anything. Would be nice if there was a test for whatever these should have fixed...
levino
commented
Jul 29, 2020
| "@storybook/addon-links": "^5.3.19", | ||
| "@storybook/addons": "^5.3.19", | ||
| "@storybook/preset-create-react-app": "^3.1.4", | ||
| "@storybook/react": "^5.3.19", |
There was a problem hiding this comment.
These were in twice. Oopsy.
levino
commented
Jul 29, 2020
| @@ -36,12 +42,19 @@ const PreviewItem = styled("div")` | |||
| // Consider upgrading react-dnd BUT somehow try to keep IE11 compatibility | |||
| //@ts-ignore | |||
|
|
|||
| const generatePreview = (type, item, style) => { | |||
| const DragPreview = () => { | |||
| const { item, style, display } = usePreview(); | |||
There was a problem hiding this comment.
Using the hook api now after updating react-dnd-multi-backend
levino
force-pushed
the
feature/issue-24-touch-and-hold-to-drag
branch
from
6e5645b to
6e044b0
Compare
jakobkolb
approved these changes
Jul 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable touch and hold to drag. Coincidentally, drag to scroll on mobile also works.
fix #36, fix #25
Make start script also start the mock backend for easier dev setup. Fixes #1264.