Skip to content

Fix single file publish #2088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Feb 23, 2023
Merged

Fix single file publish #2088

merged 7 commits into from
Feb 23, 2023

Conversation

stesee
Copy link
Contributor

@stesee stesee commented Feb 13, 2023 •
edited by kblok
Loading

closes #2073

@kblok kblok changed the title Fixed https://github.com/hardkoded/puppeteer-sharp/issues/2073 Fix single file publish Feb 14, 2023
kblok
kblok reviewed Feb 14, 2023
View reviewed changes
Copy link
Member

@kblok kblok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@stesee
Fixed review findings
f5b2045 
Fixed some errors caused by outdated test adapter serching for .net core 2.1
@kblok
Copy link
Member

kblok commented Feb 15, 2023

@amaitland as you stepped into this, I'll wait for your approval.

@amaitland
Copy link
Contributor

@kblok Just ran the latest changes locally, happy to approve for merge 👍

@stesee stesee requested a review from kblok February 22, 2023 14:09
@kblok kblok merged commit c18812b into hardkoded:master Feb 23, 2023
@jnyrup jnyrup mentioned this pull request Apr 7, 2023
Closed
@stesee stesee deleted the PublishUsingProduceSingleFileFix branch April 10, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amaitland amaitland amaitland left review comments

@kblok kblok Awaiting requested review from kblok

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@stesee @kblok @amaitland @seeste