Fix: Turn on PdfOopif for PDF viewer (#2629)#3273
Merged
Conversation
Enable PdfOopif feature flag in Chrome launcher to support PDF viewer in out-of-process iframes. Add tests for exposeFunction and evaluate on pages with embedded PDF viewers. Port of upstream puppeteer/puppeteer#12370. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PdfOopifChrome feature flag in the launcher to support PDF viewer in out-of-process iframespdf-viewer.htmlandsample.pdftest assetsShouldExposeFunctionOnAPageWithAPdfViewerandShouldEvaluateOnAPageWithAPdfViewerUpstream Reference
Port of puppeteer/puppeteer#12370.
Chrome's PDF viewer replaces inner iframes with extension web views, which are not supported by Puppeteer. Enabling
PdfOopifmakes Chrome use out-of-process iframes for PDF viewing instead, which Puppeteer already supports.Changes
ChromeLauncher.csPdfOopifto default enabled Chrome featuresOOPIFTests.cswwwroot/pdf-viewer.htmlwwwroot/sample.pdfTest plan
🤖 Generated with Claude Code