feat: add ElementHandle.AsLocator() (upstream alignment)#3383
Merged
Conversation
Add AsLocator() method to IElementHandle and ElementHandle that converts an existing ElementHandle into a Locator, matching upstream Puppeteer's asLocator() API. Introduces HandleLocator, an internal locator that wraps an element handle directly. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This was referenced Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AsLocator()method toIElementHandleinterface andElementHandleabstract class, matching upstream Puppeteer'sasLocator()APIHandleLocatorclass inPuppeteerSharp.Locatorsthat wraps an existingIElementHandledirectly, returning it fromWaitHandleCoreAsyncwithout querying the DOMTest plan
dotnet build PuppeteerSharp/PuppeteerSharp.csprojsucceeds with 0 warnings, 0 errorsdotnet build PuppeteerSharp.Tests/PuppeteerSharp.Tests.csprojcompiles successfully (only pre-existing dev cert error in TestServer)🤖 Generated with Claude Code