Skip to content

Conversation

DHANUSHRAJA22
Copy link
Contributor

This PR fixes the CI failure in PR #117 by adding the missing normalise_text function to the harmony.parsing.util module.

Problem

The HTML parser introduced in PR #117 tries to import normalise_text from harmony.parsing.util, but this function doesn't exist in the current codebase, causing all 21 test modules to fail with ImportError.

Solution

Added a simple normalise_text() function that:

  • Strips leading/trailing whitespace
  • Removes extra internal whitespace
  • Converts text to lowercase

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Testing

This fix directly addresses the ImportError that was causing all tests to fail. Once merged, the CI should pass successfully.

Checklist

Adds the missing normalise_text function that was causing ImportError in HTML parser and preventing all tests from passing. This function normalizes text by removing extra whitespace and converting to lowercase as required by PR #117.

Description

Please include a summary of the change and which issue is fixed. Please also include relevant context. List any dependencies that are required for this change. Ideally we avoid introducing any new third party dependencies in requirements.txt and pyproject.toml unless absolutely necessary, because this makes the project more susceptible to breaking whenever a third party library is updated.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Requires a documentation revision

Testing

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Since the Harmony Python package is used by the Harmony API (which is itself used by the R library and the web app), we need to avoid making any changes that break the Harmony API. Please also run the Harmony API unit tests and check that the API still runs with your changes to the Python package: https://github.com/harmonydata/harmonyapi

Test Configuration

  • Library version:
  • OS:
  • Toolchain:

Checklist

  • My PR is for one issue, rather than for multiple unrelated fixes.
  • My code follows the style guidelines of this project. I have applied a Linter (recommended: Pycharm's code formatter) to make my whitespace consistent with the rest of the project.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • The Harmony API is not broken by my change to the Harmony Python library
  • I add third party dependencies only when necessary. If I changed the requirements, it changes in requirements.txt, pyproject.toml and also in the requirements.txt in the API repo
  • If I introduced a new feature, I documented it (e.g. making a script example in the script examples repository so that people will know how to use it.

Optionally: feel free to paste your Discord username in this format: discordapp.com/users/yourID in your pull request description, then we can know to tag you in the Harmony Discord server when we announce the PR.

…issing normalise_text function to fix ImportError in HTML parserUpdate __init__.py

Adds the missing normalise_text function that was causing ImportError in HTML parser and preventing all tests from passing. This function normalizes text by removing extra whitespace and converting to lowercase as required by PR harmonydata#117.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants