fix: add missing normalise_text function to resolve ImportError and CI failurefix: add missing normalise_text function to fix ImportErrorfix: add m… #118
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the CI failure in PR #117 by adding the missing
normalise_text
function to theharmony.parsing.util
module.Problem
The HTML parser introduced in PR #117 tries to import
normalise_text
fromharmony.parsing.util
, but this function doesn't exist in the current codebase, causing all 21 test modules to fail with ImportError.Solution
Added a simple
normalise_text()
function that:Type of change
Testing
This fix directly addresses the ImportError that was causing all tests to fail. Once merged, the CI should pass successfully.
Checklist
Adds the missing normalise_text function that was causing ImportError in HTML parser and preventing all tests from passing. This function normalizes text by removing extra whitespace and converting to lowercase as required by PR #117.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant context. List any dependencies that are required for this change. Ideally we avoid introducing any new third party dependencies in
requirements.txt
andpyproject.toml
unless absolutely necessary, because this makes the project more susceptible to breaking whenever a third party library is updated.Fixes # (issue)
Type of change
Please delete options that are not relevant.
Testing
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Since the Harmony Python package is used by the Harmony API (which is itself used by the R library and the web app), we need to avoid making any changes that break the Harmony API. Please also run the Harmony API unit tests and check that the API still runs with your changes to the Python package: https://github.com/harmonydata/harmonyapi
Test Configuration
Checklist
requirements.txt
,pyproject.toml
and also in therequirements.txt
in the API repoOptionally: feel free to paste your Discord username in this format:
discordapp.com/users/yourID
in your pull request description, then we can know to tag you in the Harmony Discord server when we announce the PR.