Skip to content

Update winsafe to v0.0.27#119

Closed
madsmtm wants to merge 1 commit intoharryfei:masterfrom
madsmtm:update-deps
Closed

Update winsafe to v0.0.27#119
madsmtm wants to merge 1 commit intoharryfei:masterfrom
madsmtm:update-deps

Conversation

@madsmtm
Copy link
Copy Markdown
Contributor

@madsmtm madsmtm commented Mar 6, 2026

Might fix my problem in rodrigocfd/winsafe#185.

@Xaeroxe
Copy link
Copy Markdown
Collaborator

Xaeroxe commented Mar 6, 2026

Hey, please rebase this on the latest master branch so that this can be tested against Rust 1.70. Thank you for your PR!

@madsmtm madsmtm changed the title Update dependencies Update winsafe to v0.0.27 Mar 7, 2026
@madsmtm
Copy link
Copy Markdown
Contributor Author

madsmtm commented Mar 7, 2026

I changed this PR to only update winsafe, getrandom seemed to have issues with MSRV

@Xaeroxe
Copy link
Copy Markdown
Collaborator

Xaeroxe commented Mar 7, 2026

We are bumping MSRV to 1.85.0 to accommodate this change. I've rebased your branch on top of that change from #120

@Xaeroxe
Copy link
Copy Markdown
Collaborator

Xaeroxe commented Mar 7, 2026

Hm, well this upgrade apparently requires 1.87. That doesn't work on Debian stable so I'm hesitant to move the MSRV quite that far, however I think I've got a solution:

We only need one function definition from winsafe, why not just create that FFI definition inside which? I'll take a crack at implementing this.

@madsmtm
Copy link
Copy Markdown
Contributor Author

madsmtm commented Mar 7, 2026

We only need one function definition from winsafe, why not just create that FFI definition inside which? I'll take a crack at implementing this.

I'm also fine with this, I can recommend running windows-bindgen in a separate helper crate, see the docs and https://github.com/rust-lang/cc-rs/tree/main/dev-tools/gen-windows-sys-binding for an example.

@Xaeroxe
Copy link
Copy Markdown
Collaborator

Xaeroxe commented Mar 8, 2026

Closing in favor of #121

@Xaeroxe Xaeroxe closed this Mar 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants