Skip to content

Conversation

@easel
Copy link
Contributor

@easel easel commented Oct 28, 2020

Test against AWS Aurora Postgres v 11.7

Copy link
Owner

@hartmut-co-uk hartmut-co-uk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks, any particular reason not to use latest, which is 1.4.6?
https://github.com/reorg/pg_repack/releases

If possible - could you test if 1.4.6 also works with pg11 / your setup?

@easel
Copy link
Contributor Author

easel commented Oct 29, 2020

I can definitely test it. The reason I built 1.4.4 was that's the version AWS is using with their postgres11 instances. In an ideal scenario we'd tag 1.4.1 with postgres 10, 1.4.4 with postgres 11 and 1.4.5 / 1.4.6 with their corresponding releases as well.

@hartmut-co-uk
Copy link
Owner

Agree, good point. As I understand 1.4.6 should be fully backwards compatible though.
Please let me know if 1.4.6 works with pg11 if possible.

Also let me check if I've had integration with docker hub - or also if I might add Github actions + Github package registry support. 🤔

@hartmut-co-uk
Copy link
Owner

right - I've had it linked with docker hub: https://hub.docker.com/repository/docker/hartmutcouk/pg-repack-docker
so should work with tagging..
I'll try to get this sorted on the WE if I can find time.

Many thanks for the contribution! 👍

@easel
Copy link
Contributor Author

easel commented Oct 30, 2020

I'm pretty sure pg_repack itself is compatible, but the issue is you won't always have control of the extension version loaded into the db (with AWS RDS for example).

My assumption about this container was that it was a convenient way to isolate the "client" from the server for such scenarios, so ideally we'd have a version built for every version of pg_repack along with the most appropriate postgres version.

@hartmut-co-uk hartmut-co-uk merged commit fac53c1 into hartmut-co-uk:master Nov 1, 2020
@easel easel deleted the postgres11 branch November 1, 2020 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants