Skip to content

Conversation

@nickgal
Copy link
Contributor

@nickgal nickgal commented May 27, 2021

Adds libreadline-dev for pg_repack compile.

Here's the error I was getting before.

/usr/bin/ld: cannot find -lreadline
collect2: error: ld returned 1 exit status
make[1]: *** [/usr/lib/postgresql/13/lib/pgxs/src/makefiles/pgxs.mk:462: pg_repack] Error 1
make[1]: Leaving directory '/pg_repack-1.4.6/bin'
make: *** [Makefile:35: all] Error 2

/usr/bin/ld: cannot find -lreadline
collect2: error: ld returned 1 exit status
make[1]: *** [/usr/lib/postgresql/13/lib/pgxs/src/makefiles/pgxs.mk:462: pg_repack] Error 1
make[1]: Leaving directory '/pg_repack-1.4.6/bin'
make: *** [Makefile:35: all] Error 2
@hartmut-co-uk
Copy link
Owner

Thanks for reporting & opening the PR, let me take a look and verify how this came about.

@hartmut-co-uk
Copy link
Owner

I've been able to build current master branch without any errors - could you please provide your OS, docker version and build logs?

I assume this was during make && make install of pg_repack?

@nickgal
Copy link
Contributor Author

nickgal commented May 31, 2021

I assume this was during make && make install of pg_repack?

That is correct. It will fail during make and continue building the container "successfully".

I cloned fresh from github and still ran into the error.

Docker: 20.10.2
Operating System: Ubuntu 20.04.2 LTS
Kernel Version: 5.8.0-53-generic

env.txt
build.txt

Let me know if you would like any additional information.

@hartmut-co-uk
Copy link
Owner

got it, thanks, good catch!

@hartmut-co-uk hartmut-co-uk merged commit 4675803 into hartmut-co-uk:master May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants