Skip to content

Upgrades #2541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 24, 2019
Merged

Upgrades #2541

merged 4 commits into from
Jan 24, 2019

Conversation

rebeccacremona
Copy link
Contributor

This PR upgrades Django, and also upgrades any other packages permitted by our constraints specified Pipfile. See Pipfile.lock for a complete list. Of note:

  • This commit has landed in django-ratelimit. So, that plus the new setting I added to settings_common.py means we should no longer run into the situation where perma-dev.org goes out of commission due to overstepping our redis instance's limits.

  • Upgrades to pytest and pytest-django went too far for pytest-django-ordering; I have a PR out to upgrade the package, but in the meantime have pinned us to use my fork.

  • The most recent version of fakeredis is a release candidate, which is too bleeding edge for our code, so I've pinned us to only accept minor and point releases for now.

Everything else seems to have upgraded without problems.

NOTE FOR DEPLOYMENT: I ran into some trouble with pipenv hanging when generating this new lockfile, possibly due to user error re: the package we are installing from my fork. There's no reason there should be trouble, but if anything funny happens, I recommend deleting any pip cache that's on the minion and trying again, and/or throwing out the virtualenv and starting fresh.

@rebeccacremona
Copy link
Contributor Author

Yeah, this failed on Travis in the way I initially saw locally....... I think it's a virtualenv problem, investigating.....

@rebeccacremona
Copy link
Contributor Author

The failure was due to the wrong version of Django being installed.

The wrong version of Django was being installed because of the combination of pip 9.0.1, pipenv installing the dependencies in synchronous mode, and installing my forked version of pytest-django-ordering from github using setup.py, which mentions that it requires django but correctly does not specify what version.

Upgrading pip>=9.0.2 was sufficient to solve the problem; running with pip==9.0.1 and pipenv --sequential also solves the problem.

@bensteinberg bensteinberg merged commit 7e955d6 into harvard-lil:develop Jan 24, 2019
@coveralls
Copy link

Coverage Status

Coverage remained the same at 83.31% when pulling 58f1fe9 on rebeccacremona:upgrade-django into 56c1121 on harvard-lil:develop.

@rebeccacremona rebeccacremona deleted the upgrade-django branch January 24, 2019 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants