Add hi, pl, ko to JSON Schema language maps#43
Merged
hasaneyldrm merged 1 commit intoJul 16, 2026
Conversation
The schema was added before the Hindi (73b0c68) and Polish/Korean (118e4bd) instructions landed, so languageMap and languageStepsMap still only declared en, es, it, tr, ru, zh. All 1,324 records carry all nine languages and the README documents nine, but `additionalProperties` let hi/pl/ko through unvalidated and unrequired — a record silently missing them still passed validation. Declare all nine in `properties` and `required` for both maps. Verified: the 1,324 records validate cleanly against the updated schema, and a record missing hi/pl/ko is now rejected.
rarhs
added a commit
to rarhs/exercises-dataset
that referenced
this pull request
Jul 16, 2026
Adds instructions.bn and instruction_steps.bn to all 1,324 records in both data/exercises.json and the EXERCISES blob in index.html, registers Bengali in the browser UI language tabs, and updates the README (language count 10 -> 11, schema table, sample record, usage examples). Following the precedent of hasaneyldrm#43/hasaneyldrm#44, bn is added to the JSON Schema language maps as a required language. Also adds the instructions_fr / instructions_bn columns to the SQL templates and insert generator in setup.html — the French PR (hasaneyldrm#44) had updated the LLM prompt but not the SQL generation, so generated SQL silently dropped French text.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
data/exercises.schema.jsonwas added in a081e72, before the Hindi (73b0c68) and Polish/Korean (118e4bd) instructions landed. It was never updated, solanguageMapandlanguageStepsMapstill declare only six languages:Meanwhile all 1,324 records ship nine languages, and the README documents nine.
Because both maps set
additionalProperties,hi/pl/kowere accepted but never validated or required — so a record silently missing them still passed validation. The schema couldn't catch the exact regression it exists to catch.Change
Declare all nine languages in
propertiesandrequiredfor bothlanguageMapandlanguageStepsMap. Data files are untouched.Verification
With
jsonschema(Draft 2020-12), against the realdata/exercises.json:hi/pl/kovs. old schemahi/pl/kovs. new schemainstructions.ruset to a non-stringNo behavior change for consumers already producing complete records; the schema now simply matches what the dataset and README already promise.