refactor: 💡 Change variable name for peeking db #2954
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Base automatically changed from
ICU-17410-add-initial-query-handler-and-sql-parser
to
llb/migrate-to-sqlite
August 6, 2025 15:09
ZedLi
force-pushed
the
update-peekdb-parameter
branch
from
03c856c to
488ac4e
Compare
DhariniJeeva
approved these changes
Aug 6, 2025
calcaide
approved these changes
Aug 7, 2025
ZedLi
added a commit
that referenced
this pull request
Aug 18, 2025
ZedLi
added a commit
that referenced
this pull request
Sep 2, 2025
ZedLi
added a commit
that referenced
this pull request
Sep 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change the
peekIndexedDBparameter to be more generic so it can also be shared with sqlite.How to Test
Try any of the resources and confirm that it still works by using searches that bring back no results.
Checklist
[ ] I have added before and after screenshots for UI changes[ ] I have added JSON response output for API changes[ ] I have added steps to reproduce and test for bug fixes in the description[ ] I have commented on my code, particularly in hard-to-understand areas[ ] I have added tests that prove my fix is effective or that my feature worksPCI review checklist
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.