Skip to content

[FE-112] Boundary Enterprise a11y audit- User details form #2977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[FE-112] Boundary Enterprise a11y audit- User details form #2977

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ed04192
refactor: 💡 add edit-user-details translations
venusang Aug 26, 2025
f7082ea
refactor: 💡 change inputs to readonly and update submit button
venusang Aug 26, 2025
334e7d6
refactor: 💡 move translation to resources for user
venusang Aug 27, 2025
d86805c
refactor: 💡 removed aria-label from button set
venusang Aug 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions addons/core/translations/resources/en-us.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -570,6 +570,7 @@ user:
actions:
add-accounts: Add Accounts
delete: Delete User
edit-details: 'Edit User details'
role:
title: Role
title_plural: Roles
Expand Down
6 changes: 3 additions & 3 deletions ui/admin/app/components/form/user/index.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
@value={{@model.name}}
@isInvalid={{@model.errors.name}}
@isOptional={{true}}
disabled={{form.disabled}}
readonly={{form.disabled}}
{{on 'input' (set-from-event @model 'name')}}
as |F|
>
Expand All @@ -36,7 +36,7 @@
@value={{@model.description}}
@isInvalid={{@model.errors.description}}
@isOptional={{true}}
disabled={{form.disabled}}
readonly={{form.disabled}}
as |F|
>
<F.Label>{{t 'form.description.label'}}</F.Label>
Expand All @@ -52,7 +52,7 @@

{{#if (can 'save model' @model)}}
<form.actions
@enableEditText={{t 'actions.edit-form'}}
@enableEditText={{t 'resources.user.actions.edit-details'}}
@submitText={{t 'actions.save'}}
@cancelText={{t 'actions.cancel'}}
/>
Expand Down