Add warnings to the customer facing Boundary API. #3347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talanknight
force-pushed
the
alanknight_warnings
branch
from
ae83656 to
0be93a0
Compare
talanknight
force-pushed
the
alanknight_warnings
branch
from
f1d4d7e to
01303d4
Compare
Warnings are helpful for deprecation notices or when a request configures Boundary in a way that is valid but might not work as intended. A recent example of where warnings might be helpful is when a user updates a target's "filter" field which is deprecated in favor of "ingress_worker_filter" or "egress_worker_filter".
…ng them to the response.
talanknight
force-pushed
the
alanknight_warnings
branch
from
d9e55a4 to
90dbd44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warnings are helpful for deprecation notices or when a request configures Boundary in a way that is valid but might not work as intended. A recent example of where warnings might be helpful is when a user updates a target's "filter" field which is deprecated in favor of "ingress_worker_filter" or "egress_worker_filter".
This PR is a draft for now while the RFC is being reviewed and discussions are ongoing.