fix: AppSideNav types

Author: shleewhite

packages/components/src/components/hds/app-side-nav/portal/index.ts

@@ -7,21 +7,8 @@ import TemplateOnlyComponent from '@ember/component/template-only';
 
 import type { HdsAppSideNavListSignature } from '../list/index';
 
-// TODO! understand how this should be done "correctly"
-// import type { PortalSignature } from 'ember-stargate/components/portal';
-interface PortalSignature {
-  Args: {
-    target: string;
-    renderInPlace?: boolean;
-    fallback?: 'inplace';
-  };
-  Blocks: {
-    default: [];
-  };
-}
-
 export interface HdsAppSideNavPortalSignature {
-  Args: PortalSignature['Args'] & {
+  Args: {
     ariaLabel?: string;
     targetName?: string;
   };

packages/components/src/components/hds/app-side-nav/portal/target.ts

@@ -10,24 +10,10 @@ import { action } from '@ember/object';
 import { macroCondition, isTesting } from '@embroider/macros';
 
 import type { HdsAppSideNavPortalSignature } from './index';
-
-// import { PortalTargetSignature } from 'ember-stargate/components/portal-target';
-interface PortalTargetSignature {
-  Element: HTMLDivElement;
-  Args: {
-    name: string;
-    multiple?: boolean;
-    onChange?: (count: number) => void;
-  };
-  Blocks: {
-    default: [number];
-  };
-}
-
 import type { Registry as Services } from '@ember/service';
 
 interface HdsAppSideNavPortalTargetSignature {
-  Args: PortalTargetSignature['Args'] & {
+  Args: {
     targetName?: HdsAppSideNavPortalSignature['Args']['targetName'];
   };
   Element: HTMLDivElement;

packages/components/src/components/hds/side-nav/portal/index.ts

@@ -7,21 +7,8 @@ import TemplateOnlyComponent from '@ember/component/template-only';
 
 import type { HdsSideNavListSignature } from '../list/index';
 
-// TODO! understand how this should be done "correctly"
-// import type { PortalSignature } from 'ember-stargate/components/portal';
-export interface PortalSignature {
-  Args: {
-    target: string;
-    renderInPlace?: boolean;
-    fallback?: 'inplace';
-  };
-  Blocks: {
-    default: [];
-  };
-}
-
 export interface HdsSideNavPortalSignature {
-  Args: PortalSignature['Args'] & {
+  Args: {
     ariaLabel?: string;
     targetName?: string;
   };

packages/components/src/components/hds/side-nav/portal/target.ts

@@ -11,23 +11,10 @@ import { macroCondition, isTesting } from '@embroider/macros';
 
 import type { HdsSideNavPortalSignature } from './index';
 
-// import { PortalTargetSignature } from 'ember-stargate/components/portal-target';
-export interface PortalTargetSignature {
-  Element: HTMLDivElement;
-  Args: {
-    name: string;
-    multiple?: boolean;
-    onChange?: (count: number) => void;
-  };
-  Blocks: {
-    default: [number];
-  };
-}
-
 import type { Registry as Services } from '@ember/service';
 
 export interface HdsSideNavPortalTargetSignature {
-  Args: PortalTargetSignature['Args'] & {
+  Args: {
     targetName?: HdsSideNavPortalSignature['Args']['targetName'];
   };
   Element: HTMLDivElement;