Table: make checkbox aria-labels stay the same regardless of checkbox state
#2596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
didoo
reviewed
Dec 11, 2024
dchyun
approved these changes
Dec 12, 2024
|
[Question] Is this something we would want to add for 4.15? |
@dchyun it can go out in the next release with all of the other table/advanced table stuff |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
If merged, this PR would update the select all and select row checkbox labels so the visually hidden label is always
Select {selectionAriaLabelSuffix}and update the default of selectionAriaLabelSuffix to be 'row'.It is not compliant to have the label of a form input change based on the state of the input because it makes it harder for users to find again / understand what the input is for. Instead, it is better to keep the input name consistent and let the screen reader use the html attributes on the input to convey the state (in this case, checked or unchecked).
📸 Screenshots
Before
After
🔗 External links
Jira ticket: HDS-4258
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.