Skip to content

CodeEditor and CodeBlock: add ability to customize the copy button text #2696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Feb 12, 2025
Merged

CodeEditor and CodeBlock: add ability to customize the copy button text #2696

merged 9 commits into from
Feb 12, 2025

Conversation

shleewhite
Copy link
Contributor

@shleewhite shleewhite commented Feb 11, 2025 •
edited
Loading

📌 Summary

CodeEditor: add @copyButtonText argument
CodeBlock: add @copyButtonText argument to the CodeBlock component and @text argument to the CopyButton sub-component.

Website preview

🛠️ Detailed description

  • add new arguments
  • add tests to ensure arguments are working
  • update website content

📸 Screenshots

Screenshot 2025-02-11 at 11 58 44 AM Screenshot 2025-02-11 at 11 59 06 AM

🔗 External links

Jira ticket: HDS-4389

👀 Component checklist

💬 Please consider using conventional comments when reviewing this PR.

@vercel Vercel
Copy link

vercel bot commented Feb 11, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
hds-showcase ✅ Ready (Inspect) Visit Preview Feb 11, 2025 9:29pm
hds-website ✅ Ready (Inspect) Visit Preview Feb 11, 2025 9:29pm

@hashibot-hds hashibot-hds added the docs-website Content updates to the documentation website label Feb 11, 2025
@shleewhite shleewhite marked this pull request as ready for review February 11, 2025 19:13
@shleewhite shleewhite requested review from a team as code owners February 11, 2025 19:13
dchyun
dchyun previously approved these changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@dchyun dchyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just a couple small docs comments.

@shleewhite shleewhite requested a review from dchyun February 11, 2025 21:26
KristinLBradley
KristinLBradley approved these changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@KristinLBradley KristinLBradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@shleewhite shleewhite merged commit 109d71f into main Feb 12, 2025
14 checks passed
@shleewhite shleewhite deleted the hds-4389/copy-btn-text-arg branch February 12, 2025 14:59
@hashibot-hds hashibot-hds mentioned this pull request Feb 11, 2025
Merged
@alex-ju alex-ju added this to the [email protected] milestone Feb 27, 2025
shleewhite added a commit that referenced this pull request Mar 10, 2025
@shleewhite @dchyun
CodeEditor and CodeBlock: add ability to customize the copy butto…
f49c9e6 
…n text (#2696)

Co-authored-by: Dylan Hyun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dchyun dchyun dchyun approved these changes

@KristinLBradley KristinLBradley KristinLBradley approved these changes

Assignees
No one assigned
Labels
docs-website Content updates to the documentation website packages/components showcase
Projects
None yet
Milestone
[email protected]
Development

Successfully merging this pull request may close these issues.
5 participants
@shleewhite @dchyun @KristinLBradley @alex-ju @hashibot-hds