Skip to content

Conversation

dchyun
Copy link
Contributor

@dchyun dchyun commented Jun 12, 2025

๐Ÿ“Œ Summary

If merged, this PR would enhance the display of OptionGroup options in the SuperSelect::Multiple, when only selected options are shown.

PREVIEW

๐Ÿ› ๏ธ Detailed description

Currently in the OptionGroup of the Super::Select::Multiple, when the "show selected" button is used to only show selected options, if no options are selected the group and sub-group titles are shown with no options.

This differs from the pattern used on super selects that do not contain groups. In those instances there is nothing shown in the menu besides the noMatchesMessage.

Screenshot 2025-06-12 at 2 36 02โ€ฏPM

In this PR we have made it so when "show selected" is active, the group or sub-group title of an option is only visible when an option in that group is selected. If a group / sub-group contains no selection options then their titles are not shown.

๐Ÿ“ธ Screenshots

"Show selected" with no options selected

Before
Screenshot 2025-06-12 at 2 17 47โ€ฏPM

After
Screenshot 2025-06-12 at 2 19 11โ€ฏPM

"Show selected" with some options selected

Before
Screenshot 2025-06-12 at 2 18 57โ€ฏPM

After
Screenshot 2025-06-12 at 2 19 24โ€ฏPM

๐Ÿ”— External links

Jira ticket: HDS-4775


๐Ÿ‘€ Component checklist

๐Ÿ’ฌ Please consider using conventional comments when reviewing this PR.

๐Ÿ“‹ PCI review checklist
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've worked with GRC to document the impact of any changes to security controls.
    Examples of changes to controls include access controls, encryption, logging, etc.
  • If applicable, I've worked with GRC to ensure compliance due to a significant change to the in-scope PCI environment.
    Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.

Copy link

vercel bot commented Jun 12, 2025

The latest updates on your projects. Learn more about Vercel for Git โ†—๏ธŽ

Name Status Preview Updated (UTC)
hds-showcase โœ… Ready (Inspect) Visit Preview Jul 1, 2025 1:07pm
hds-website โœ… Ready (Inspect) Visit Preview Jul 1, 2025 1:07pm

shleewhite
shleewhite previously approved these changes Jun 23, 2025
Copy link
Contributor

@KristinLBradley KristinLBradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @shleewhite I can't think of a better way to select these using CSS than what you have

shleewhite
shleewhite previously approved these changes Jun 24, 2025
@shleewhite shleewhite added this to the [email protected] milestone Jun 25, 2025
jorytindall
jorytindall previously approved these changes Jun 30, 2025
Copy link
Contributor

@jorytindall jorytindall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, this is a nice improvement! We don't really have the concept of grouped options in Figma (at least from a layout perspective), so I don't think any changes are needed in design tooling.

@dchyun dchyun merged commit f500715 into main Jul 1, 2025
17 of 18 checks passed
@dchyun dchyun deleted the dchyun/super-select-groups-show-selected branch July 1, 2025 17:09
@hashibot-hds hashibot-hds mentioned this pull request Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants