Skip to content

Conversation

dchyun
Copy link
Contributor

@dchyun dchyun commented Jul 29, 2025

📌 Summary

If merged, this PR would fix type issues found in the Table and AdvancedTable for the following argument.

  • isSelected in the sub-component Tr
    • Change type from false to boolean
  • selectionKey in the sub-component Tr
    • Update docs for type from string | number to string to reflect accurate argument type

🛠️ Detailed description

The type issues in the table components were caught while converting their showcase pages to TS.

isSelected

Currently in the sub-components Table::Tr and AdvancedTable::Tr the isSelected argument set to the type false. This means that anytime isSelected is set to true a type error is thrown.
Screenshot 2025-07-29 at 11 10 33 AM

The type has now been set to boolean and a getter has been added to set this.isSelected to false by default.

🔗 External links

Jira ticket: HDS-5183


👀 Component checklist

💬 Please consider using conventional comments when reviewing this PR.

📋 PCI review checklist
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've worked with GRC to document the impact of any changes to security controls.
    Examples of changes to controls include access controls, encryption, logging, etc.
  • If applicable, I've worked with GRC to ensure compliance due to a significant change to the in-scope PCI environment.
    Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.

Copy link

vercel bot commented Jul 29, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
hds-showcase ✅ Ready (Inspect) Visit Preview Jul 30, 2025 5:15pm
hds-website ✅ Ready (Inspect) Visit Preview Jul 30, 2025 5:15pm

@dchyun dchyun force-pushed the dchyun/table-type-fixes branch from f1ac619 to f4083af Compare July 30, 2025 14:00
@dchyun dchyun changed the title Table & AdvancedTable - Type fixes for isSelected and selectionKey Table & AdvancedTable - Type fixes for isSelected Jul 30, 2025
@dchyun dchyun requested a review from a team as a code owner July 30, 2025 14:03
@hashibot-hds hashibot-hds added the docs-website Content updates to the documentation website label Jul 30, 2025
didoo
didoo previously approved these changes Jul 30, 2025
@didoo
Copy link
Contributor

didoo commented Jul 30, 2025

@dchyun for some reason the tests for the website are failing. I've tried to re-run the tests, but they failed again 🤷‍♂️

@dchyun
Copy link
Contributor Author

dchyun commented Jul 30, 2025

@dchyun for some reason the tests for the website are failing. I've tried to re-run the tests, but they failed again 🤷‍♂️

@didoo @shleewhite one of the files in the website for the icon didn't get updated to the new type name changes in #3063. Have a PR up to fix it in #3071

@dchyun dchyun force-pushed the dchyun/table-type-fixes branch from b53e6fb to b1fd7d5 Compare July 30, 2025 17:10
@dchyun dchyun merged commit fef3baa into main Jul 30, 2025
16 checks passed
@dchyun dchyun deleted the dchyun/table-type-fixes branch July 30, 2025 17:29
@hashibot-hds hashibot-hds mentioned this pull request Jul 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-website Content updates to the documentation website packages/components showcase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants