-
Notifications
You must be signed in to change notification settings - Fork 51
Table
& AdvancedTable
- Type fixes for isSelected
#3066
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
f1ac619
to
f4083af
Compare
Table
& AdvancedTable
- Type fixes for isSelected
and selectionKey
Table
& AdvancedTable
- Type fixes for isSelected
@dchyun for some reason the tests for the website are failing. I've tried to re-run the tests, but they failed again 🤷♂️ |
@didoo @shleewhite one of the files in the website for the icon didn't get updated to the new type name changes in #3063. Have a PR up to fix it in #3071 |
b53e6fb
to
b1fd7d5
Compare
📌 Summary
If merged, this PR would fix type issues found in the
Table
andAdvancedTable
for the following argument.isSelected
in the sub-componentTr
false
toboolean
selectionKey
in the sub-componentTr
string | number
tostring
to reflect accurate argument type🛠️ Detailed description
The type issues in the table components were caught while converting their showcase pages to TS.
isSelected
Currently in the sub-components

Table::Tr
andAdvancedTable::Tr
theisSelected
argument set to the typefalse
. This means that anytimeisSelected
is set totrue
a type error is thrown.The type has now been set to
boolean
and a getter has been added to setthis.isSelected
tofalse
by default.🔗 External links
Jira ticket: HDS-5183
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.
📋 PCI review checklist
Examples of changes to controls include access controls, encryption, logging, etc.
Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.