Skip to content

Showcase - Convert Table route to TS #3067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Aug 7, 2025
Merged

Showcase - Convert Table route to TS #3067

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
4fc94a6
HDS-5076 Feat: Convert Table showcase pages to TS
dchyun Jul 29, 2025
28ee54c
Feat: Add `ember-composable-helpers` to showcase devDependencies
dchyun Jul 29, 2025
a506d4a
Fix: Remove testing example from table template
dchyun Jul 29, 2025
0aba88d
Fix: Set `@selectionKey` in showcase to string values
dchyun Jul 30, 2025
1531252
Fix: Update lockfile
dchyun Aug 4, 2025
f615b9d
Fix: Use `console.group` in controller
dchyun Aug 4, 2025
dc36108
Fix: Remove unneeded check for `H.setSortBy`
dchyun Aug 4, 2025
0235272
Feat: Align table controller to adv table controller
dchyun Aug 7, 2025
b1e572e
Fix: Update `console.group` titles
dchyun Aug 7, 2025
b33a4da
Fix: Linting
dchyun Aug 7, 2025
3cea4bc
Feat: Update table to use new data imports
dchyun Aug 7, 2025
d0ac2c1
Fix: Adv table - Broken delete rows example, unused data
dchyun Aug 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 5 additions & 3 deletions showcase/app/controllers/page-components/advanced-table.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ import { deepTracked } from 'ember-deep-tracked';
import { later } from '@ember/runloop';

import type { PageComponentsAdvancedTableModel } from 'showcase/routes/page-components/advanced-table';
import type { SelectableItem } from 'showcase/mocks/selectable-item-data';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😎 nice

import type { User } from 'showcase/mocks/user-data';

import type {
HdsAdvancedTableOnSelectionChangeSignature,
Expand All @@ -25,12 +27,12 @@ const customSortingCriteriaArray = [
'pending',
];

const updateModelWithSelectAllState = <T>(
modelData: T[],
const updateModelWithSelectAllState = (
modelData: SelectableItem[] | User[],
selectAllState: boolean,
) => {
modelData.forEach((modelRow) => {
if (modelRow instanceof Object && 'isSelected' in modelRow) {
if (modelRow instanceof Object) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Note] The userData data doesn't have isSelected set, so this check was breaking the "delete row" example's "expand scope" toggle, which used the userData and this function. The type has been updated to be more specific to ensure modelRow.isSelected is available.

modelRow.isSelected = selectAllState;
}
});
Expand Down
Loading