-
Notifications
You must be signed in to change notification settings - Fork 51
Update AppHeader
default breakpoint
#3072
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
MelSumner
reviewed
Jul 30, 2025
KristinLBradley
approved these changes
Jul 30, 2025
heatherlarsen
approved these changes
Jul 30, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
zamoore
approved these changes
Jul 31, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
MelSumner
approved these changes
Jul 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
Updates the default breakpoint of the
AppHeader
fromlg
(1088px) tomd
(768px).🛠️ Detailed description
During the implementation of the Enterprise Navigation components, initial testing has solicited feedback around the default breakpoint at which the
AppHeader
collapses being too large; e.g., the elements in theAppHeader
collapse into the small viewport menu at too large a size.This presents some usability issues and can make it cumbersome to access the context switcher and other high-level navigation elements even at reasonable viewport widths (for example, when a desktop user has multiple tabs open next to one-another).
This was discussed in Slack here.
While potentially out-of-date (or anecdotal), we do have viewport usage metrics from TFC which validates that this change will result in the
AppHeader
being displayed in its uncollapsed state for >95% of users.What this does not account for nor solve is very long strings in the context switcher that might result in wrapping. However, we believe this to be an edge case and the resulting experience is not broken.
The
AppSideNav
still collapses at thelg
breakpoint, so while each component shifts at different breakpoints, it's logical to to keep theAppSideNav
the same to free up space in the main page.🔗 External links
Jira ticket: HDS-5164
Figma file: Enterprise Nav Breakpoints
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.
📋 PCI review checklist
Examples of changes to controls include access controls, encryption, logging, etc.
Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.